Merge m into cggmp24/m

[survived]

Sync cggmp24/m branch with m

I additionally pushed some commits after the merge commit to address that CI was not working on cggmp24/m branch, and consequentially we had some workflows failing

[github-actions]

Crate direct deps

Direct deps

cggmp21-keygen v0.5.0 (/home/runner/work/cggmp21/cggmp21/pr_branch/cggmp21-keygen)
digest v0.10.6
futures v0.3.24
generic-ec v0.4.1
generic-ec-zkp v0.4.1
hex v0.4.3
key-share v0.6.0 (/home/runner/work/cggmp21/cggmp21/pr_branch/key-share)
paillier-zk v0.4.2 (/home/runner/work/cggmp21/cggmp21/pr_branch/paillier-zk)
rand_core v0.6.4
rand_hash v0.1.0
round-based v0.4.0
serde v1.0.193
serde_with v2.3.3
sha2 v0.10.6
thiserror v1.0.48
udigest v0.2.1

Compared to base branch

Diff

--- direct-deps-base	2024-12-18 14:16:37.085030023 +0000
+++ direct-deps-pr	2024-12-18 14:16:37.456028715 +0000
@@ -1 +1 @@
-cggmp21-keygen v0.4.0 (/home/runner/work/cggmp21/cggmp21/base_branch/cggmp21-keygen)
+cggmp21-keygen v0.5.0 (/home/runner/work/cggmp21/cggmp21/pr_branch/cggmp21-keygen)
@@ -7,2 +7,2 @@
-key-share v0.5.2 (/home/runner/work/cggmp21/cggmp21/base_branch/key-share)
-paillier-zk v0.4.2 (/home/runner/work/cggmp21/cggmp21/base_branch/paillier-zk)
+key-share v0.6.0 (/home/runner/work/cggmp21/cggmp21/pr_branch/key-share)
+paillier-zk v0.4.2 (/home/runner/work/cggmp21/cggmp21/pr_branch/paillier-zk)
@@ -11 +11 @@
-round-based v0.3.0
+round-based v0.4.0

All deps

cargo tree

cggmp21 v0.6.0 (/home/runner/work/cggmp21/cggmp21/pr_branch/cggmp21)
├── cggmp21-keygen v0.5.0 (/home/runner/work/cggmp21/cggmp21/pr_branch/cggmp21-keygen)
│   ├── digest v0.10.6
│   │   ├── block-buffer v0.10.3
│   │   │   └── generic-array v0.14.6
│   │   │       ├── serde v1.0.193
│   │   │       │   └── serde_derive v1.0.193 (proc-macro)
│   │   │       │       ├── proc-macro2 v1.0.92
│   │   │       │       │   └── unicode-ident v1.0.4
│   │   │       │       ├── quote v1.0.37
│   │   │       │       │   └── proc-macro2 v1.0.92 (*)
│   │   │       │       └── syn v2.0.90
│   │   │       │           ├── proc-macro2 v1.0.92 (*)
│   │   │       │           ├── quote v1.0.37 (*)
│   │   │       │           └── unicode-ident v1.0.4
│   │   │       └── typenum v1.15.0
│   │   └── crypto-common v0.1.6
│   │       ├── generic-array v0.14.6 (*)
│   │       └── typenum v1.15.0
│   ├── displaydoc v0.2.5 (proc-macro)
│   │   ├── proc-macro2 v1.0.92 (*)
│   │   ├── quote v1.0.37 (*)
│   │   └── syn v2.0.90 (*)
│   ├── generic-ec v0.4.1
│   │   ├── digest v0.10.6 (*)
│   │   ├── generic-ec-core v0.2.0
│   │   │   ├── generic-array v0.14.6 (*)
│   │   │   ├── rand_core v0.6.4
│   │   │   ├── serde v1.0.193 (*)
│   │   │   ├── subtle v2.4.1
│   │   │   └── zeroize v1.6.0
│   │   │       └── zeroize_derive v1.3.2 (proc-macro)
│   │   │           ├── proc-macro2 v1.0.92 (*)
│   │   │           ├── quote v1.0.37 (*)
│   │   │           ├── syn v1.0.101
│   │   │           │   ├── proc-macro2 v1.0.92 (*)
│   │   │           │   ├── quote v1.0.37 (*)
│   │   │           │   └── unicode-ident v1.0.4
│   │   │           └── synstructure v0.12.6
│   │   │               ├── proc-macro2 v1.0.92 (*)
│   │   │               ├── quote v1.0.37 (*)
│   │   │               ├── syn v1.0.101 (*)
│   │   │               └── unicode-xid v0.2.4
│   │   ├── hex v0.4.3
│   │   │   └── serde v1.0.193 (*)
│   │   ├── phantom-type v0.4.2
│   │   │   └── educe v0.4.19 (proc-macro)
│   │   │       ├── enum-ordinalize v3.1.11 (proc-macro)
│   │   │       │   ├── num-bigint v0.4.3
│   │   │       │   │   ├── num-integer v0.1.45
│   │   │       │   │   │   └── num-traits v0.2.15
│   │   │       │   │   └── num-traits v0.2.15
│   │   │       │   ├── num-traits v0.2.15
│   │   │       │   ├── proc-macro2 v1.0.92 (*)
│   │   │       │   ├── quote v1.0.37 (*)
│   │   │       │   └── syn v1.0.101 (*)
│   │   │       ├── proc-macro2 v1.0.92 (*)
│   │   │       ├── quote v1.0.37 (*)
│   │   │       └── syn v1.0.101 (*)
│   │   ├── rand_core v0.6.4
│   │   ├── rand_hash v0.1.0
│   │   │   ├── digest v0.10.6 (*)
│   │   │   ├── rand_core v0.6.4
│   │   │   └── udigest v0.2.1
│   │   │       ├── digest v0.10.6 (*)
│   │   │       └── udigest-derive v0.3.0 (proc-macro)
│   │   │           ├── proc-macro2 v1.0.92 (*)
│   │   │           ├── quote v1.0.37 (*)
│   │   │           └── syn v2.0.90 (*)
│   │   ├── serde v1.0.193 (*)
│   │   ├── serde_with v2.3.3
│   │   │   ├── serde v1.0.193 (*)
│   │   │   └── serde_with_macros v2.3.3 (proc-macro)
│   │   │       ├── darling v0.20.1
│   │   │       │   ├── darling_core v0.20.1
│   │   │       │   │   ├── fnv v1.0.7
│   │   │       │   │   ├── ident_case v1.0.1
│   │   │       │   │   ├── proc-macro2 v1.0.92 (*)
│   │   │       │   │   ├── quote v1.0.37 (*)
│   │   │       │   │   ├── strsim v0.10.0
│   │   │       │   │   └── syn v2.0.90 (*)
│   │   │       │   └── darling_macro v0.20.1 (proc-macro)
│   │   │       │       ├── darling_core v0.20.1 (*)
│   │   │       │       ├── quote v1.0.37 (*)
│   │   │       │       └── syn v2.0.90 (*)
│   │   │       ├── proc-macro2 v1.0.92 (*)
│   │   │       ├── quote v1.0.37 (*)
│   │   │       └── syn v2.0.90 (*)
│   │   ├── subtle v2.4.1
│   │   ├── udigest v0.2.1 (*)
│   │   └── zeroize v1.6.0 (*)
│   ├── generic-ec-zkp v0.4.1
│   │   ├── generic-array v0.14.6 (*)
│   │   ├── generic-ec v0.4.1 (*)
│   │   ├── rand_core v0.6.4
│   │   ├── serde v1.0.193 (*)
│   │   ├── subtle v2.4.1
│   │   └── udigest v0.2.1 (*)
│   ├── hex v0.4.3 (*)
│   ├── key-share v0.6.0 (/home/runner/work/cggmp21/cggmp21/pr_branch/key-share)
│   │   ├── displaydoc v0.2.5 (proc-macro) (*)
│   │   ├── generic-ec v0.4.1 (*)
│   │   ├── generic-ec-zkp v0.4.1 (*)
│   │   ├── hex v0.4.3 (*)
│   │   ├── serde v1.0.193 (*)
│   │   ├── serde_with v2.3.3 (*)
│   │   └── thiserror v1.0.48
│   │       └── thiserror-impl v1.0.48 (proc-macro)
│   │           ├── proc-macro2 v1.0.92 (*)
│   │           ├── quote v1.0.37 (*)
│   │           └── syn v2.0.90 (*)
│   ├── rand_core v0.6.4
│   ├── round-based v0.4.0
│   │   ├── futures-util v0.3.24
│   │   │   ├── futures-channel v0.3.24
│   │   │   │   ├── futures-core v0.3.24
│   │   │   │   └── futures-sink v0.3.24
│   │   │   ├── futures-core v0.3.24
│   │   │   ├── futures-io v0.3.24
│   │   │   ├── futures-macro v0.3.24 (proc-macro)
│   │   │   │   ├── proc-macro2 v1.0.92 (*)
│   │   │   │   ├── quote v1.0.37 (*)
│   │   │   │   └── syn v1.0.101 (*)
│   │   │   ├── futures-sink v0.3.24
│   │   │   ├── futures-task v0.3.24
│   │   │   ├── memchr v2.5.0
│   │   │   ├── pin-project-lite v0.2.9
│   │   │   ├── pin-utils v0.1.0
│   │   │   └── slab v0.4.7
│   │   ├── phantom-type v0.3.1
│   │   │   └── educe v0.4.19 (proc-macro) (*)
│   │   ├── round-based-derive v0.2.2 (proc-macro)
│   │   │   ├── proc-macro2 v1.0.92 (*)
│   │   │   ├── quote v1.0.37 (*)
│   │   │   └── syn v1.0.101 (*)
│   │   ├── thiserror v2.0.4
│   │   │   └── thiserror-impl v2.0.4 (proc-macro)
│   │   │       ├── proc-macro2 v1.0.92 (*)
│   │   │       ├── quote v1.0.37 (*)
│   │   │       └── syn v2.0.90 (*)
│   │   └── tracing v0.1.36
│   │       ├── cfg-if v1.0.0
│   │       ├── pin-project-lite v0.2.9
│   │       └── tracing-core v0.1.29
│   ├── serde v1.0.193 (*)
│   ├── serde_with v2.3.3 (*)
│   ├── sha2 v0.10.6
│   │   ├── cfg-if v1.0.0
│   │   ├── cpufeatures v0.2.12
│   │   └── digest v0.10.6 (*)
│   ├── thiserror v1.0.48 (*)
│   └── udigest v0.2.1 (*)
├── digest v0.10.6 (*)
├── futures v0.3.24
│   ├── futures-channel v0.3.24 (*)
│   ├── futures-core v0.3.24
│   ├── futures-executor v0.3.24
│   │   ├── futures-core v0.3.24
│   │   ├── futures-task v0.3.24
│   │   └── futures-util v0.3.24 (*)
│   ├── futures-io v0.3.24
│   ├── futures-sink v0.3.24
│   ├── futures-task v0.3.24
│   └── futures-util v0.3.24 (*)
├── generic-ec v0.4.1 (*)
├── generic-ec-zkp v0.4.1 (*)
├── hex v0.4.3 (*)
├── key-share v0.6.0 (/home/runner/work/cggmp21/cggmp21/pr_branch/key-share) (*)
├── paillier-zk v0.4.2 (/home/runner/work/cggmp21/cggmp21/pr_branch/paillier-zk)
│   ├── digest v0.10.6 (*)
│   ├── fast-paillier v0.1.0
│   │   ├── bytemuck v1.13.1
│   │   │   └── bytemuck_derive v1.4.1 (proc-macro)
│   │   │       ├── proc-macro2 v1.0.92 (*)
│   │   │       ├── quote v1.0.37 (*)
│   │   │       └── syn v2.0.90 (*)
│   │   ├── rand_core v0.6.4
│   │   ├── rug v1.21.0
│   │   │   ├── az v1.2.1
│   │   │   ├── gmp-mpfr-sys v1.6.1
│   │   │   │   └── libc v0.2.153
│   │   │   ├── libc v0.2.153
│   │   │   └── serde v1.0.193 (*)
│   │   ├── serde v1.0.193 (*)
│   │   └── thiserror v1.0.48 (*)
│   ├── generic-ec v0.4.1 (*)
│   ├── rand_core v0.6.4
│   ├── rand_hash v0.1.0 (*)
│   ├── rug v1.21.0 (*)
│   ├── serde v1.0.193 (*)
│   ├── serde_with v3.0.0
│   │   ├── serde v1.0.193 (*)
│   │   └── serde_with_macros v3.0.0 (proc-macro)
│   │       ├── darling v0.20.1 (*)
│   │       ├── proc-macro2 v1.0.92 (*)
│   │       ├── quote v1.0.37 (*)
│   │       └── syn v2.0.90 (*)
│   ├── thiserror v1.0.48 (*)
│   └── udigest v0.2.1 (*)
├── rand_core v0.6.4
├── rand_hash v0.1.0 (*)
├── round-based v0.4.0 (*)
├── serde v1.0.193 (*)
├── serde_with v2.3.3 (*)
├── sha2 v0.10.6 (*)
├── thiserror v1.0.48 (*)
└── udigest v0.2.1 (*)

Compared to base branch

Diff

--- all-deps-base	2024-12-18 14:16:37.226029526 +0000
+++ all-deps-pr	2024-12-18 14:16:37.606028187 +0000
@@ -6 +6 @@
-cggmp21-keygen v0.4.0 (/home/runner/work/cggmp21/cggmp21/base_branch/cggmp21-keygen)
+cggmp21-keygen v0.5.0 (/home/runner/work/cggmp21/cggmp21/pr_branch/cggmp21-keygen)
@@ -34 +34 @@
-key-share v0.5.2 (/home/runner/work/cggmp21/cggmp21/base_branch/key-share)
+key-share v0.6.0 (/home/runner/work/cggmp21/cggmp21/pr_branch/key-share)
@@ -40 +40 @@
-paillier-zk v0.4.2 (/home/runner/work/cggmp21/cggmp21/base_branch/paillier-zk)
+paillier-zk v0.4.2 (/home/runner/work/cggmp21/cggmp21/pr_branch/paillier-zk)
@@ -45,2 +45,2 @@
-proc-macro2 v1.0.66
-quote v1.0.33
+proc-macro2 v1.0.92
+quote v1.0.37
@@ -49,2 +49,2 @@
-round-based v0.3.0
-round-based-derive v0.2.1 (proc-macro)
+round-based v0.4.0
+round-based-derive v0.2.2 (proc-macro)
@@ -63 +63 @@
-syn v2.0.32
+syn v2.0.90
@@ -65,0 +66 @@
+thiserror v2.0.4
@@ -66,0 +68 @@
+thiserror-impl v2.0.4 (proc-macro)

[github-actions]

The spec was successfully compiled. PDF is available here.

[github-actions]

Benchmark Result

Benchmarks

RUST_TESTS_SEED=ec27aa0010acfed4a220362e94e961565d5dd9b81a6f7f3ccd943230dd04f291
n = 3

Non-threshold DKG
Protocol Performance:
  - Protocol took 423.10µs to complete
In particular:
  - Stage: 6.38µs
    - Setup networking: 6.12µs (95.9%)
    - Unstaged: 260.00ns (4.1%)
  - Round 1: 145.06µs
    - Sample x_i, rid_i, chain_code: 64.55µs (44.5%)
    - Sample schnorr commitment: 57.95µs (39.9%)
    - Commit to public data: 22.25µs (15.3%)
    - Unstaged: 311.00ns (0.2%)
  - Round 2: 1.22µs
    - Hash received msgs (reliability check): 1.05µs (85.9%)
    - Unstaged: 172.00ns (14.1%)
  - Round 3: 271.00ns
    - Assert other parties hashed messages (reliability check): 151.00ns (55.7%)
    - Unstaged: 120.00ns (44.3%)
  - Round 4: 36.55µs
    - Validate decommitments: 32.99µs (90.3%)
    - Calculate chain_code: 1.04µs (2.9%)
    - Calculate challege rid: 2.13µs (5.8%)
    - Prove knowledge of `x_i`: 240.00ns (0.7%)
    - Unstaged: 140.00ns (0.4%)
  - Round 5: 233.62µs
    - Validate schnorr proofs: 233.30µs (99.9%)
    - Unstaged: 311.00ns (0.1%)


Threshold DKG
Protocol Performance:
  - Protocol took 1.31ms to complete
In particular:
  - Stage: 2.23µs
    - Setup networking: 2.16µs (96.9%)
    - Unstaged: 70.00ns (3.1%)
  - Round 1: 219.33µs
    - Sample rid_i, schnorr commitment, polynomial, chain_code: 193.96µs (88.4%)
    - Commit to public data: 25.14µs (11.5%)
    - Unstaged: 230.00ns (0.1%)
  - Round 2: 1.25µs
    - Hash received msgs (reliability check): 1.10µs (88.0%)
    - Unstaged: 150.00ns (12.0%)
  - Round 3: 360.00ns
    - Assert other parties hashed messages (reliability check): 220.00ns (61.1%)
    - Unstaged: 140.00ns (38.9%)
  - Round 4: 795.28µs
    - Validate decommitments: 48.28µs (6.1%)
    - Validate data size: 501.00ns (0.1%)
    - Validate Feldmann VSS: 347.60µs (43.7%)
    - Compute rid: 260.00ns (0.0%)
    - Compute chain_code: 651.00ns (0.1%)
    - Compute Ys: 364.42µs (45.8%)
    - Compute sigma: 471.00ns (0.1%)
    - Calculate challenge: 32.63µs (4.1%)
    - Prove knowledge of `sigma_i`: 321.00ns (0.0%)
    - Unstaged: 150.00ns (0.0%)
  - Round 5: 296.54µs
    - Validate schnorr proofs: 295.30µs (99.6%)
    - Derive resulting public key and other data: 982.00ns (0.3%)
    - Unstaged: 260.00ns (0.1%)


Auxiliary data generation protocol
Protocol Performance:
  - Protocol took 9.58s to complete
In particular:
  - Stage: 18.08µs
    - Retrieve auxiliary data: 100.00ns (0.6%)
    - Setup networking: 17.93µs (99.2%)
    - Unstaged: 50.00ns (0.3%)
  - Round 1: 1.17s
    - Retrieve primes (p and q): 80.00ns (0.0%)
    - Compute paillier decryption key (N): 6.07µs (0.0%)
    - Generate auxiliary params r, λ, t, s: 9.08ms (0.8%)
    - Prove Πprm (ψˆ_i): 1.16s (99.2%)
    - Sample random bytes: 2.55µs (0.0%)
    - Compute hash commitment and sample decommitment: 299.60µs (0.0%)
    - Unstaged: 240.00ns (0.0%)
  - Round 2: 1.63µs
    - Hash received msgs (reliability check): 1.25µs (76.7%)
    - Unstaged: 381.00ns (23.3%)
  - Round 3: 451.00ns
    - Assert other parties hashed messages (reliability check): 250.00ns (55.4%)
    - Unstaged: 201.00ns (44.6%)
  - Round 4: 5.91s
    - Validate round 1 decommitments: 606.33µs (0.0%)
    - Validate П_prm (ψ_i): 2.29s (38.7%)
    - Add together shared random bytes: 1.01µs (0.0%)
    - Compute П_mod (ψ_i): 3.45s (58.4%)
    - Assemble security params for П_fac (ф_i): 6.60µs (0.0%)
    - Compute П_fac (ф_i^j): 173.03ms (2.9%)
    - Unstaged: 980.00ns (0.0%)
  - Round 5: 2.50s
    - Validate ψ_j (П_mod): 2.33s (93.1%)
    - Validate ф_j (П_fac): 172.96ms (6.9%)
    - Assemble auxiliary info: 155.55µs (0.0%)
    - Unstaged: 501.00ns (0.0%)


Signing protocol
Protocol Performance:
  - Protocol took 1.60s to complete
In particular:
  - Stage: 144.01µs
    - Map t-out-of-n protocol to t-out-of-t: 74.37µs (51.6%)
    - Retrieve auxiliary data: 65.67µs (45.6%)
    - Precompute execution id and security params: 441.00ns (0.3%)
    - Setup networking: 3.44µs (2.4%)
    - Unstaged: 90.00ns (0.1%)
  - Round 1: 117.52ms
    - Generate local ephemeral secrets (k_i, y_i, p_i, v_i): 50.15µs (0.0%)
    - Encrypt G_i and K_i: 35.93ms (30.6%)
    - Prove ψ0_j: 81.54ms (69.4%)
    - Unstaged: 620.00ns (0.0%)
  - Round 2: 14.89µs
    - Hash received msgs (reliability check): 14.68µs (98.6%)
    - Unstaged: 210.00ns (1.4%)
  - Round 3: 807.22ms
    - Assert other parties hashed messages (reliability check): 501.00ns (0.0%)
    - Verify psi0 proofs: 92.72ms (11.5%)
    - Sample random r, hat_r, s, hat_s, beta, hat_beta: 14.06µs (0.0%)
    - Encrypt D_ji: 70.56ms (8.7%)
    - Encrypt F_ji: 36.05ms (4.5%)
    - Encrypt hat_D_ji: 70.77ms (8.8%)
    - Encrypt hat_F_ji: 35.97ms (4.5%)
    - Prove psi_ji: 209.78ms (26.0%)
    - Prove psiˆ_ji: 209.72ms (26.0%)
    - Prove psi_prime_ji : 81.62ms (10.1%)
    - Unstaged: 1.91µs (0.0%)
  - Round 4: 577.91ms
    - Retrieve auxiliary data: 4.12µs (0.0%)
    - Validate psi: 165.81ms (28.7%)
    - Validate hat_psi: 165.35ms (28.6%)
    - Validate psi_prime: 92.93ms (16.1%)
    - Compute Gamma, Delta_i, delta_i, chi_i: 72.19ms (12.5%)
    - Prove psi_prime_prime: 81.63ms (14.1%)
    - Unstaged: 601.00ns (0.0%)
  - Presig output: 92.89ms
    - Validate psi_prime_prime: 92.76ms (99.9%)
    - Calculate presignature: 132.16µs (0.1%)
    - Unstaged: 921.00ns (0.0%)
  - Partial signing: 8.10µs
  - Signature reconstruction: 196.90µs

[survived]

@maurges I did some other changes in PR other than merging, see https://github.com/LFDT-Lockness/cggmp21/pull/126/files/c66918583665b489bbffd9b1df51ed9279cd17aa..d506fc2b392acf6a0ea04719b0ef0b465f7ae31f

[survived]

Ah sorry, CI is still broken, it appeared fixed at a time. Pushed new commit, hopefully that will do it

[survived]

Yep it finally worked

[maurges]

Is it required because of a slash in the branch name? This is silly

[survived]

Yep exactly