use two-step casting to silence incompatible function type warning #249
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like a recent GitHub actions change caused our Windows CI builds to fail in the
clangcl
config due to-Werror
and-Wcast-function-type-mismatch
:We can silence this warning with a two-step cast, e.g.
We do this a couple of other places in the OpenCL ICD loader by casting through
size_t
, but I think casting throughvoid*
is more common. If desired though, I can switch tosize_t
, or turn the other casts tovoid*
for consistency.