Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add compatibility support for QNX Neutrino #248

Merged
merged 1 commit into from
Mar 9, 2025

Conversation

xi-guo-0
Copy link
Contributor

@xi-guo-0 xi-guo-0 commented Mar 6, 2025

Based on #149

Changes

This pull request adds support for QNX in the ICD loader by making the following changes:

  • Platform Definition

    • Added __QNXNTO__ to icd_platform.h to properly define platform-specific path separators and directory symbols.
  • Directory Enumeration Fix

    • QNX requires a different way to access d_type in directory entries. Adjusted icd_linux.c to use _DEXTRA_FIRST(dirEntry)->d_type when compiling for QNX.
  • Environment Variable Handling

    • Updated icd_linux_envvars.c to treat QNX like macOS, as QNX does not have a secure_getenv implementation.

Testing

These changes have been tested on Qualcomm SA8155P and SA8295P platforms:

Platform OS Version
SA8155P QNX 7.0, Android
SA8295P QNX 7.1, Android

QNX 7.0.0 _DEXTRA_FIRST reference
QNX 7.1 _DEXTRA_FIRST reference

@CLAassistant
Copy link

CLAassistant commented Mar 6, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@bashbaug bashbaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I don't have an easy way to test these changes, but they shouldn't break any of our existing configs.

The CI failure is unrelated to your changes. Thanks!

@bashbaug bashbaug merged commit d547426 into KhronosGroup:main Mar 9, 2025
31 of 33 checks passed
@xi-guo-0 xi-guo-0 deleted the build-qnx branch March 10, 2025 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants