Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RuleApp interface for all external solvers (prep for #3514) #3521

Merged
merged 4 commits into from
Nov 13, 2024

Conversation

BookWood7th
Copy link
Contributor

@BookWood7th BookWood7th commented Oct 23, 2024

Related Issue

#3514

Intended Change

Currently goals are only closed if the associated taclet is a closing taclet or alternatively if the rule application is a SMTRuleApp.
To enable other external solvers to close goals, this pull request adds a layer of abstraction that is used instead of SMTRuleApp to determine if the goal was closed.

Plan

Type of pull request

  • Refactoring (behaviour should not change or only minimally change)
  • There are changes to the (Java) code

Ensuring quality

  • I made sure that introduced/changed code is well documented (javadoc and inline comments).
  • I have tested the feature as follows: KeY test suite
  • I have checked that runtime performance has not deteriorated.

Additional information and contact(s)

The contributions within this pull request are licensed under GPLv2 (only) for inclusion in KeY.

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 7.69231% with 12 lines in your changes missing coverage. Please review.

Project coverage is 38.15%. Comparing base (3bdb527) to head (3c41ebb).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
...a/ilkd/key/rule/AbstractExternalSolverRuleApp.java 0.00% 11 Missing ⚠️
.../src/main/java/de/uka/ilkd/key/smt/SMTRuleApp.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3521      +/-   ##
============================================
- Coverage     38.17%   38.15%   -0.02%     
+ Complexity    17227    17221       -6     
============================================
  Files          2110     2110              
  Lines        127652   127630      -22     
  Branches      21464    21461       -3     
============================================
- Hits          48727    48703      -24     
- Misses        72934    72935       +1     
- Partials       5991     5992       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BookWood7th BookWood7th marked this pull request as ready for review November 13, 2024 13:17
@WolframPfeifer WolframPfeifer self-requested a review November 13, 2024 13:18
Copy link
Member

@WolframPfeifer WolframPfeifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@WolframPfeifer WolframPfeifer added this pull request to the merge queue Nov 13, 2024
Merged via the queue into KeYProject:main with commit c19bb8e Nov 13, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants