Remove Ctrl+C handling, see #3456 #3499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test cases seem to fail (on ubuntu at least ...). @WolframPfeifer and @FliegendeWurst are perhaps better reviewers. |
FliegendeWurst
approved these changes
Jul 20, 2024
WolframPfeifer
approved these changes
Aug 13, 2024
There was a problem hiding this comment.
The original PR that introduced this feature (#3249) was meant as an experimental idea to recover from some out-of-memory situations. However, it seems that it does more harm than good (OOM should be quite rare hopefully), so I am ok with just removing the feature to restore default shell behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the explicit ctrl+c handling in
WindowsUserInterfaceControlSee bug report: #3456.