-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proof caching: use dependency graph to increase hit rate #3305
Proof caching: use dependency graph to increase hit rate #3305
Conversation
keyext.slicing/src/main/java/org/key_project/slicing/analysis/AnalysisResults.java
Show resolved
Hide resolved
Co-Authored-By: Richard Bubel <bubel@cs.tu-darmstadt.de>
Head branch was pushed to by a user without write access
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this improvement! As already discussed, for easier generation of a meaningful changelog, the PR title could be improved. I have only two small remarks/requests (see comments in code).
keyext.slicing/src/main/java/org/key_project/slicing/ui/SlicingLeftPanel.java
Show resolved
Hide resolved
keyext.slicing/src/main/java/org/key_project/slicing/graph/EquivalenceDirectedGraph.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these nicely documented PR with convenience and efficiency features!
The only small suggestion from my side would be to remove the white box from the icon, such that it fits our icon design better.
This is now done. |
Previously when searching for a reference, the entire sequent of the old proof had to be present in the new proof.
Now, only the useful subset of the old sequent has to be present.
Tested by a unit test.
Additional functionality: