refactor/data-layer #253
Merged
refactor/data-layer #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update `MarketDetailDtoMapper` to use `toMarketDetail` and `toMarketData` for mapping `MarketDetailResponse` to `MarketDetail` domain model. - Modify `MarketData` model to hold values of `high24hUSD`, `low24hUSD`, `marketCapUSD` and `marketCapRank`. - Remove redundant intermediate classes for high, low and market cap in `MarketData`. - Update UI components to reflect changes in the `MarketDetail` domain model. - Update `MarketDetailState` to handle nullable `MarketDetail`. - Set default value for properties of `MarketDetail` model.
The .gitignore file has been updated to ignore additional build artifacts and IDE-generated files, enhancing the cleanliness of the repository. Specifically, these changes include: - Adding the pattern `/*/build` to ignore build directories that are in nested structures. - Adding `.kotlin` files to the list of ignored files.
VahidGarousi
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: Pull request
about: Create a pull request
label: 'triage me'
./git-hooks/setup.shFixes #<issue_number_goes_here> 🦕