Refactor tests #251
Merged
Refactor tests #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added comprehensive tests for `toMarket` and `toRemoteMarketDto` mappers, covering valid, empty, extreme, and negative value scenarios. - Updated `kotest` to version `6.0.0.M1`.
- Implement detailed test cases in `MarketEntityMapperTest` to cover various scenarios. - Add test cases for empty strings, zero values, extreme double values, and negative values. - Add test cases for handling `isFavorite` as both true and false. - Improve the equality checks in the tests. - Refactor existing test cases to use shouldBe instead of shouldBeEqual. - remove unnecessary imports.
VahidGarousi
reviewed
Feb 6, 2025
|
|
||
| val market = marketResponse.toMarket() | ||
|
|
||
| market shouldBeEqual marketResponse |
There was a problem hiding this comment.
Suggested change
| market shouldBeEqual marketResponse | |
| MarketResponse( | |
| id = "extreme", | |
| name = "Extreme Market", | |
| symbol = "ext", | |
| currentPrice = Double.MAX_VALUE, | |
| priceChangePercentage24h = Double.MIN_VALUE, | |
| imageUrl = "https://image.url/extreme.png", | |
| ).toMarket() shouldBeEqual marketResponse |
VahidGarousi
reviewed
Feb 6, 2025
|
|
||
| val market = marketEntity.toMarket() | ||
|
|
||
| market shouldBeEqual marketEntity |
There was a problem hiding this comment.
Suggested change
| market shouldBeEqual marketEntity | |
| MarketEntity( | |
| id = "bitcoin", | |
| name = "Bitcoin", | |
| symbol = "btc", | |
| currentPrice = 20000.0, | |
| priceChangePercentage24h = 2.0, | |
| imageUrl = "https://image.url/bitcoin.png", | |
| isFavorite = FALSE, | |
| ).toMarket() shouldBeEqual marketEntity |
VahidGarousi
requested changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor existing tests in
data:market-repositorymodule.close #250