Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: emit additional event on reset_team #874

Open
wants to merge 3 commits into
base: bonded-coins-audit-fixes
Choose a base branch
from

Conversation

rflechtner
Copy link
Contributor

@rflechtner rflechtner commented Mar 11, 2025

fixes KILTProtocol/ticket#3813

Following recommendations by OAK, this adds another event to be emitted on calling reset_team. This is emitted in addition to the events emitted by the assets pallet itself.

Checklist:

  • I have verified that the code works
    • No panics! (checked arithmetic ops, no indexing array[3] use get(3), ...)
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)
    • Either PR or Ticket to update the Docs
    • Link the PR/Ticket here

@rflechtner rflechtner marked this pull request as ready for review March 12, 2025 10:54
@rflechtner rflechtner requested review from ntn-x2 and abdulmth March 12, 2025 11:14
@rflechtner
Copy link
Contributor Author

Feedback about the necessity of this change is welcomed on the linked ticket (https://github.com/KILTprotocol/ticket/issues/3813)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant