Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: bonded coins audit fixes #873

Draft
wants to merge 12 commits into
base: develop
Choose a base branch
from
Draft

refactor: bonded coins audit fixes #873

wants to merge 12 commits into from

Conversation

rflechtner
Copy link
Contributor

fixes KILTProtocol/ticket#3795

Branch containing all changes from the bonded coins pallet audit.

Checklist:

  • I have verified that the code works
    • No panics! (checked arithmetic ops, no indexing array[3] use get(3), ...)
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)
    • Either PR or Ticket to update the Docs
    • Link the PR/Ticket here

Ad96el and others added 11 commits February 26, 2025 11:03
@Ad96el @rflechtner
fix: ensure at least one currency in pool (#844)
916f83f 
## fixes [#3747](KILTprotocol/ticket#3747)
@rflechtner
fix: only destroy funds on refund if collateral received is BelowMini…
957e162 
…mum (#866)

Adopts the recommended resolution of audit issue #2.
@rflechtner
fix: increase MaxConsumers to allow accounts to hold more than 15 dif…
7e481bb 
…ferent bonded coins (#868)

fix for audit issue #3
@rflechtner
refactor: batch updating of asset team (#869)
cc4475c 
fixes audit issue 6
@rflechtner
feat: disallow re-using token names and symbols within a pool (#870)
7793ece 
## fixes adit issue 8

Disallows re-using the same token symbol or name. Empty names and
symbols are always allowed.
@rflechtner
chore: remove redundant defensive assertion
ac8a4ca 
Fixes audit issue #10
@rflechtner
fix: make sure the reset_team trait actually sets the owner (#865)
9591662 
### Fixes audit issue 7.
@rflechtner
fix: do not allow lock states that are equivalent to unlocked (#871)
3e37282 
## fixes audit issue 11
@rflechtner
fix: do not compute terms if we know the result to be 0 (#817)
dd08d84 
## fixes audit issue 12
@rflechtner
docs: explain that coefficients to the antiderivative are to be provided
608b272 
addresses audit issue 15
@rflechtner
chore: remove TODOs in pallet-bonded-coins
d403baf
@rflechtner rflechtner changed the title Bonded coins audit fixes refactor: bonded coins audit fixes Mar 10, 2025
@rflechtner
fix: prohibit manager changes on non-live pools (#872)
8287f9d 
## fixes audit issue 13

Disallows manager changes after a pool has been moved to refunding or
destroying.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rflechtner @Ad96el