Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prohibit manager changes on non-live pools #872

Merged
merged 2 commits into from
Mar 10, 2025
Merged

fix: prohibit manager changes on non-live pools #872

merged 2 commits into from
Mar 10, 2025

Conversation

rflechtner
Copy link
Contributor

@rflechtner rflechtner commented Mar 10, 2025 •
edited
Loading

fixes https://github.com/KILTprotocol/ticket/issues/3808

Disallows manager changes after a pool has been moved to refunding or destroying.

Checklist:

  • I have verified that the code works
    • No panics! (checked arithmetic ops, no indexing array[3] use get(3), ...)
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)
    • Either PR or Ticket to update the Docs
    • Link the PR/Ticket here

@rflechtner rflechtner requested review from abdulmth and ntn-x2 March 10, 2025 14:41
@rflechtner rflechtner merged commit 8287f9d into bonded-coins-audit-fixes Mar 10, 2025
13 of 15 checks passed
@rflechtner rflechtner deleted the audit-issue-13 branch March 10, 2025 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntn-x2 ntn-x2 ntn-x2 approved these changes

@abdulmth abdulmth Awaiting requested review from abdulmth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rflechtner @ntn-x2