-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make sure the reset_team trait actually sets the owner #865
Conversation
@ntn-x2 pinging you to have a look at this issue. What do you think about the implementation of ownership change? |
_(origin as T::RuntimeOrigin, pool_id, fungibles_team, max_currencies); | ||
_( | ||
origin as T::RuntimeOrigin, | ||
pool_id.clone(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not clone()
as part of the benchmark itself, but do it before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes https://github.com/KILTprotocol/ticket/issues/3802
Changes the reset_team trait to actually set the owner passed to the function.
The trait implementation is a back-port of a trait implemented in latest versions of pallet-assets (https://docs.rs/pallet-assets/41.0.0/pallet_assets/pallet/struct.Pallet.html#impl-ResetTeam%3C%3CT+as+Config%3E::AccountId%3E-for-Pallet%3CT,+I%3E). Changing ownership of an asset is part of this trait but was not implemented here as not needed.
Nevertheless, we're adding this now to avoid mismatched expectations.
TBD
Checklist:
array[3]
useget(3)
, ...)