Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reset team on refund #786

Draft
wants to merge 2 commits into
base: bonded-coins-audit-fixes
Choose a base branch
from

Conversation

rflechtner
Copy link
Contributor

@rflechtner rflechtner commented Nov 5, 2024

Suggested change to avoid unexpected changes to currencies and issuances while refunding. This resets all asset teams to the pool account when calling start_refund.

This is waiting for a runtime implementation of our new pallet so that we can see the impact on the transaction weight that this has.

Checklist:

  • I have verified that the code works
    • No panics! (checked arithmetic ops, no indexing array[3] use get(3), ...)
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)
    • Either PR or Ticket to update the Docs
    • Link the PR/Ticket here

@rflechtner rflechtner changed the base branch from develop to pallet_bonded_coins November 5, 2024 15:09
@rflechtner rflechtner mentioned this pull request Nov 5, 2024
7 tasks
rflechtner added a commit that referenced this pull request Nov 7, 2024
Tests currently failing (fix TBD in another PR):

- [ ] Team cannot be reset when pool is not live (fixed by
#786)
@rflechtner rflechtner force-pushed the feat-reset-team-on-refund branch from c59b04b to 1ad53b2 Compare November 26, 2024 12:10
@Dudleyneedham
Copy link
Member

@rflechtner What is this?

@rflechtner
Copy link
Contributor Author

@rflechtner What is this?

We can pick this up after trialing the pallet on a testnet. We're currently not quite sure if we want to reset the asset admins when the pool moves to refunding state. This would do it, but would need to be benchmarked properly.

Base automatically changed from pallet_bonded_coins to develop December 12, 2024 16:28
@rflechtner rflechtner force-pushed the feat-reset-team-on-refund branch from 62680ee to 305e8a7 Compare February 6, 2025 09:27
@rflechtner rflechtner force-pushed the feat-reset-team-on-refund branch from 305e8a7 to 59856a5 Compare March 6, 2025 17:02
@rflechtner rflechtner changed the base branch from develop to bonded-coins-audit-fixes March 6, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants