Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: more accurate weights for staking heavy operations #725

Merged
merged 7 commits into from
Sep 17, 2024

Conversation

ntn-x2
Copy link
Member

@ntn-x2 ntn-x2 commented Sep 11, 2024

Fixes https://github.com/KILTprotocol/ticket/issues/3564.

How to test

Cd into chopsticks, then yarn install and yarn spawn. Try to call execute_scheduled_reward_change with a regular account and set_inflation with sudo.

@ntn-x2 ntn-x2 self-assigned this Sep 11, 2024
@ntn-x2 ntn-x2 changed the base branch from develop to aa/zombienet September 11, 2024 13:24
@ntn-x2 ntn-x2 force-pushed the aa/staking-tx-fixes branch from 03687dd to 34855a5 Compare September 12, 2024 12:14
@ntn-x2 ntn-x2 marked this pull request as ready for review September 12, 2024 12:18
@ntn-x2 ntn-x2 requested a review from Ad96el September 12, 2024 12:18
@ntn-x2 ntn-x2 changed the base branch from aa/zombienet to develop September 12, 2024 12:57
Copy link
Member

@Ad96el Ad96el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor comment for chopsticks

@Ad96el
Copy link
Member

Ad96el commented Sep 17, 2024

I tested the execute_scheduled_reward_change in the chopsticks env

Ad96el
Ad96el previously approved these changes Sep 17, 2024
Copy link
Member

@Ad96el Ad96el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ntn-x2 ntn-x2 force-pushed the aa/staking-tx-fixes branch from d6de6b5 to f2ec1a4 Compare September 17, 2024 09:09
@ntn-x2 ntn-x2 changed the title fix: more accurate weights for heavy operations fix: more accurate weights for staking heavy operations Sep 17, 2024
@ntn-x2 ntn-x2 merged commit bb91a4c into develop Sep 17, 2024
2 checks passed
@ntn-x2 ntn-x2 deleted the aa/staking-tx-fixes branch September 17, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants