[Mellanox] support thermal sensor which has discrete index #237
+418
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n high CPU utilization scenario (sonic-net#21316) Why I did it Fix sonic-net#21314 Update and prolong the timeout of the requests between snmpd and SNMP AgentX. In SONiC SNMP AgentX, the MIB updaters and AgentX client shares the same AsyncIO/Coroutine event loop. During the MIB updaters update the SNMP values, the AgentX client can't respond to the snmpd request. The default value of snmpd request is 1s(timeout) * 5(retries) When the CPU is high, the MIB updaters are slow, 1s timeout is not enough, even if it retries 5 times. Hence update to 5s(timeout) * 4(retries), the time windows = 20s, which makes sure the SNMP request can be handled even with 100% CPU utilization. Work item tracking Microsoft ADO 30112399: How I did it Update the default value(https://linux.die.net/man/5/snmpd.conf): agentXTimeout 1(default value) -> 5 agentXRetries 5(default value) -> 4 How to verify it Test on Cisco chassis, test_snmp_cpu.py which triggers 100% CPU utilization test whether snmp requests work well.
Junchao-Mellanox
force-pushed
the
master-thermal-fix
branch
3 times, most recently
from
64d7b3f to
fd20d94
Compare
Why I did it Adding pytest-stress to sonic-mgmt image will help in running stress tests. How I did it pip install pytest-stress plugin How to verify it Manually tested the image with DUT Tested branch (Please provide the tested image version) Not applicable. Description for the changelog Adding pytest-stress to sonic-mgmt image will help in running stress tests. Link to config_db schema for YANG module changes Not applicable
Exclude pie ports from buffer and qos config Signed-off-by: Zhixin Zhu <zhixzhu@cisco.com>
Disable vstest job because sonictest agent pool is failing. To unblock PRs.
keboliu
approved these changes
Jan 9, 2025
…onic-net#21299) In SAI 11.x the SAI integrity counters is not supported completely. So, to detect packet drops due to packet corruptions or credit watchdog timeouts. We enable these interrupts and set the verbose level to error. This will generate syslogs which can be used to detect. * add sai_postinit_cmd.soc with interupt IDs for alerting * update config.bcm with the path to sai_postinit_cmd.soc * update config_bcm for j2 card --------- Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>
…sonic-net#21245) Issue to be fix: Currently operational status of mgmt interface is not present or correct for multi-asic devices. Root cause: Operational status of mgmt interface is updated by portsyncd in swss docker. In case of multi-asic platform, swss service is started only in asic namespace context. Since portsyncd is running in a specific network namespace context, it is not aware of mgmt interface present in the host namespace of multi-asic platform. Therefore there is no way for portsyncd to find the operational status of mgmt interface and update in STATE_DB MGMT_PORT_TABLE. Use case: SNMP interface MIB reads MGMT_PORT_TABLE in STATE_DB to retrieve oper status of mgmt interface periodically. In case of multi-asic platform, currently this is returning the oper status of 'eth0' interface which is the virtual interface that is present inside asic namespace which gets created as a part of database docker and is not the actual management interface. --------- Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>
…utomatically (sonic-net#21369) #### Why I did it src/sonic-host-services ``` * 744c673 - (HEAD -> master, origin/master, origin/HEAD) Fix no info log in syslog for caclmgrd (#200) (10 minutes ago) [Zhaohui Sun] ``` #### How I did it #### How to verify it #### Description for the changelog
…omatically (sonic-net#21359) #### Why I did it src/sonic-swss-common ``` * 12c428e - (HEAD -> master, origin/master, origin/HEAD) [schema] add SRv6 config db tables (sonic-net#962) (21 hours ago) [Yakiv Huryk] ``` #### How I did it #### How to verify it #### Description for the changelog
Junchao-Mellanox
force-pushed
the
master-thermal-fix
branch
from
fd20d94 to
dc91229
Compare
Junchao-Mellanox
force-pushed
the
master-thermal-fix
branch
from
dc91229 to
dcaf5a7
Compare
|
ci 308 passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Most of the thermal sensor has continues index, for example: module1_temp_input, module2_temp_input. However, there could be some thermal sensors whose index is discrete. For example, some platform only contains thermal sensor for sodimm2_temp_input, but there is no such sensor for sodimm1_temp_input.
This PR is to support thermal sensor which has discrete index.
Work item tracking
How I did it
Allow sensor with discrete index, create thermal object for it
How to verify it
manual test
unit test
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)