Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare CRAN release #48

Merged
merged 2 commits into from
Feb 17, 2024
Merged

Prepare CRAN release #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
91699dd
prepare for cran release
JosiahParry Feb 17, 2024
3c02bcb
update tests and export s3 method
JosiahParry Feb 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions NAMESPACE
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# Generated by roxygen2: do not edit by hand

S3method("[",spacetime)
S3method("[[",spacetime)
S3method(activate,spacetime)
S3method(as_spacetime,sf)
S3method(print,spacetime)
Expand Down
6 changes: 6 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
# sfdep 0.2.4

- Dexter Locke is now the maintainer of sfdep
- Address failing CRAN checks h/t [@rsbivand](https://github.com/rsbivand) <https://github.com/JosiahParry/sfdep/pull/43>
- Address bug in local Gi/* statistics

# sfdep 0.2.3

- remove readr suggestion to pass `noSuggests` from CRAN. Much minuscule tasks for the overlords.
Expand Down
3 changes: 2 additions & 1 deletion R/spacetime-methods.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,12 @@
# Selection ---------------------------------------------------------------
# Selection method
# to do update `times` attribute when subset and data is active

#' @export
`[.spacetime` <- function(x, ...) {
NextMethod()
}

#' @export
`[[.spacetime` <- function(x, ...) {
NextMethod()
}
Expand Down
4 changes: 2 additions & 2 deletions tests/testthat/test-node_get.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ test_that("nbs is spdep compliant", {
mutate(
nb = node_get_nbs(),
elist = node_get_edge_list(),
wt = node_get_edge_col(elist, "len")
wt = node_get_edge_col(nb, "len")
)


Expand All @@ -48,7 +48,7 @@ test_that("nbs is spdep compliant", {

expect_equal(
nb,
lapply(ig_adj_list, as.integer),
lapply(ig_adj_list, function(.x) unique(.x)),
ignore_attr = TRUE
)

Expand Down
Loading