Merge pull request #16 from JayBazuzi/JayBazuzi-patch-2

Add PSScriptAnalyzer to CI
JayBazuzi · Sep 14, 2021 · 1696184 · 1696184
2 parents df5964f + 0929feb
commit 1696184
Show file tree

Hide file tree

Showing 14 changed files with 44 additions and 20 deletions.
diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml
@@ -0,0 +1,14 @@
+on: [push, pull_request]
+jobs:
+  PSScriptAnalyzer:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v2
+    - name: PSScriptAnalyzer
+      uses: devblackops/github-action-psscriptanalyzer@master
+      with:
+        sendComment: true
+        failOnErrors: true
+        failOnWarnings: true
+        failOnInfos: true
+        repoToken: ${{ secrets.GITHUB_TOKEN }}
diff --git a/PSScriptAnalyzerSettings.psd1 b/PSScriptAnalyzerSettings.psd1
@@ -0,0 +1,8 @@
+@{
+    ExcludeRules = @(
+        'PSAvoidUsingInvokeExpression',
+        'PSAvoidUsingWriteHost',
+        'PSAvoidUsingCmdletAliases',
+        'PSAvoidUsingPositionalParameters'
+    )
+}
diff --git a/README.md b/README.md
@@ -1,20 +1,22 @@
+[![Build and Test](https://github.com/JayBazuzi/machine-setup/actions/workflows/CI.yml/badge.svg)](https://github.com/JayBazuzi/machine-setup/actions/workflows/CI.yml)
+
 # machine-setup
 Set up a new machine as a development environment for your project.
 
 For an example of how to use this, see: https://gist.github.com/JayBazuzi/296db9c7ecc15dad0f12287293b11125/edit and https://docs.google.com/document/d/1DyTemsYBu2LUhrwwCdNuPQDWj3f_yfMj3otaoEZZRC4/edit
 
 ## Dev Environments
 
-| Language | Status | Link | 
+| Language | Status | Link |
 | -------- | ------ | ---- |
 | C++     | Automated | [ApprovalTests, Catch2](https://github.com/approvals/ApprovalTests.cpp.StarterProject/blob/master/install.windows.ps1) |
-| C#    | Automated | [ApprovalTests, MsTest](https://github.com/approvals/ApprovalTests.Net.StarterProject/blob/master/install.windows.ps1) | 
+| C#    | Automated | [ApprovalTests, MsTest](https://github.com/approvals/ApprovalTests.Net.StarterProject/blob/master/install.windows.ps1) |
 | elixir    | Environment, No Code | [Environment setup](elixir-intellij.ps1) |
 | Elm | Requires Manual Steps |[Starting Script](dev_environments/elm.ps1)|
 | Erlang | Requires Manual Steps |[Starting Script](dev_environments/erlang.ps1)|
 | Go | Automated |[Goland](dev_environments/golang.ps1)|
 | Haskell | Requires Manual Steps |[Starting Script](dev_environments/haskell.ps1)|
-| Java     | Automated | [ApprovalTests, JUnit 5](https://github.com/approvals/ApprovalTests.java.StarterProject/blob/master/install.windows.ps1) | 
+| Java     | Automated | [ApprovalTests, JUnit 5](https://github.com/approvals/ApprovalTests.java.StarterProject/blob/master/install.windows.ps1) |
 | JavaScript | Automated |[Jest-Es6 StarterProject](https://github.com/jmasonlee/JavaScript.jest.es6.StarterProject/blob/main/MachineSetup.windows.ps1)|
 | JavaScript | Automated |[ApprovalTests, Mocha](https://github.com/approvals/ApprovalTests.js.StarterProject/blob/master/install.windows.ps1)|
 | Julia | Requires Manual Steps |[Starting Script](dev_environments/julia.ps1)|

diff --git a/dev_environments/README.md b/dev_environments/README.md
@@ -1,18 +1,18 @@
 # Dev Environments
 
-The goal here is: 
+The goal here is:
 * To have a single line that will instantiate your machine with:
     * An IDE
-    * A starter project 
+    * A starter project
     * A test framework
-    * A passing/failing test 
+    * A passing/failing test
     * The ability to run the test from the IDE
 
 **Note** All goals may not be met, currently
 
 # Process
 
-1. Many of these scripts were created with the help of Exercism  
+1. Many of these scripts were created with the help of Exercism 
    * Sign up for the track on [Exercism](https://exercism.io/my/tracks) and Practice Mode
    * Select "Hello World" and click the "Download" button on the right of the screen.
    * Paste that into your command line

diff --git a/dev_environments/elm.ps1 b/dev_environments/elm.ps1
@@ -6,7 +6,7 @@ iwr -useb https://raw.githubusercontent.com/JayBazuzi/machine-setup/main/visual-
 
 choco install nodejs
 # reload powershell to get environment running
-npm install --global elm-test@latest-0.19.1 
+npm install --global elm-test@latest-0.19.1
 npm install --global elm-format@latest-0.19.1
 cinst intellijidea
 

diff --git a/dev_environments/erlang.ps1 b/dev_environments/erlang.ps1
@@ -5,7 +5,7 @@ iwr -useb https://raw.githubusercontent.com/JayBazuzi/machine-setup/main/windows
 iwr -useb https://raw.githubusercontent.com/JayBazuzi/machine-setup/main/visual-studio.ps1 | iex
 
 choco install erlang
-choco install rebar3 
+choco install rebar3
 cinst intellijidea
 
 # intellij erlang

diff --git a/dev_environments/haskell.ps1 b/dev_environments/haskell.ps1
@@ -4,7 +4,7 @@
 iwr -useb https://raw.githubusercontent.com/JayBazuzi/machine-setup/main/windows.ps1 | iex
 iwr -useb https://raw.githubusercontent.com/JayBazuzi/machine-setup/main/visual-studio.ps1 | iex
 
-choco install haskell-stack 
+choco install haskell-stack
 cinst intellijidea
 # In IntelliJ, install the hask-force plugin and restart
 

diff --git a/dev_environments/javascript.ps1 b/dev_environments/javascript.ps1
@@ -2,5 +2,5 @@
 # Invoke-WebRequest -UseBasicParsing https://raw.githubusercontent.com/approvals/ApprovalTests.js.StarterProject/master/install.windows.ps1 | Invoke-Expression
 
 
-#Jest-Es6 StarterProject 
+#Jest-Es6 StarterProject
 # iwr -useb https://raw.githubusercontent.com/jmasonlee/JavaScript.jest.es6.StarterProject/MachineSetup.windows.ps1 | iex
diff --git a/dev_environments/reasonml.ps1 b/dev_environments/reasonml.ps1
@@ -6,7 +6,7 @@ iwr -useb https://raw.githubusercontent.com/JayBazuzi/machine-setup/main/visual-
 
 choco install nodejs
 # reload powershell to get environment running
-npm install -g bs-platform 
+npm install -g bs-platform
 cinst intellijidea
 
 # intellij reasonML

diff --git a/dev_environments/typescript.ps1 b/dev_environments/typescript.ps1
@@ -1,2 +1,2 @@
-# typescript StarterProject 
+# typescript StarterProject
 # iwr -useb https://raw.githubusercontent.com/jmasonlee/typescript.StarterProject/MachineSetup.windows.ps1 | iex
diff --git a/golang-goland.ps1 b/golang-goland.ps1
@@ -5,7 +5,7 @@
 
 iwr -useb cin.st | iex
 choco feature enable --name=allowGlobalConfirmation
-cinst golang 
+cinst golang
 cinst goland
 
 Write-Host -Foreground yellow "Reboot when done"
diff --git a/php_phpstorm.ps1 b/php_phpstorm.ps1
@@ -8,7 +8,7 @@ iwr -useb cin.st | iex
 choco feature enable --name=allowGlobalConfirmation
 choco install php
 choco install composer
-choco install phpstorm --pre 
+choco install phpstorm --pre
 
 cinst syspin --ignore-checksums
 # syspin "C:\Program Files (x86)\JetBrains\WebStorm 2020.3.2\bin\webstorm64.exe" "Pin to taskbar"

diff --git a/python-pycharm.ps1 b/python-pycharm.ps1
@@ -6,7 +6,7 @@
 iwr -useb cin.st | iex
 choco feature enable --name=allowGlobalConfirmation
 choco install beyondcompare
-choco install python --pre 
+choco install python --pre
 choco install pip
 choco install pycharm
 

diff --git a/windows.ps1 b/windows.ps1
@@ -1,6 +1,6 @@
 # This script
 # iwr -useb https://raw.githubusercontent.com/JayBazuzi/machine-setup/main/windows.ps1 | iex
- 
+
 Write-Host -Foreground yellow "Warning: You will need to Reboot when done or AnyDesk will not work properly"
 
 #Requires -RunAsAdministrator
@@ -44,11 +44,11 @@ cinst vscode
 {
     "diffEditor.ignoreTrimWhitespace": true,
     "diffEditor.renderSideBySide": false,
-    
+
     "editor.minimap.enabled": true,
     "editor.renderControlCharacters": true,
     "editor.renderWhitespace": "all",
-    
+
     "git.autofetch": true,
     "git.autofetchPeriod": 1,
     "git.enableSmartCommit": true,
@@ -78,7 +78,7 @@ syspin "C:\Program Files\internet explorer\iexplore.exe" "Unpin from taskbar"
 
 cinst taskbar-winconfig --params "'/CORTANA:no /INK:no /PEOPLE:no /TASKVIEW:no /KEYBOARD:no'"
 cuninst taskbar-winconfig
- 
+
 # Often fails because anydesk chocolatey authoring is bad
 cinst anydesk --ignore-checksums
 syspin "C:\ProgramData\chocolatey\lib\anydesk.portable\tools\AnyDesk.exe" "Pin to taskbar"