teeny fix to read_model #36
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK, I'm changing this on the dev branch which I plan to merge soon. Closing here. |
James-Thorson-NOAA
pushed a commit
that referenced
this pull request
Feb 13, 2025
James-Thorson-NOAA
added a commit
that referenced
this pull request
Feb 13, 2025
* avoid crash when quiet=FALSE and without data * adding total_effect(.) * Update test-platform.R * add `total_effect(.)` to vignette * add log-linked Poisson family * add spatial_diffusion vignette * make CI happy * another try to make CI happy * another try * small change to new vignette * allow negative lags for testing conditional independence * adding test_dsep(.) * update semantic version * fix vignettes * fix CI and add test_dsep example * use simpler stepwise_selection example * Update test_dsep.R * Update test_dsep.R * update test_dsep * updates to test_dsep * fix bug in test_dsep * Update DESCRIPTION * Update DESCRIPTION * Update DESCRIPTION * Fixes for issues #35 and #36 * add class when run_model = FALSE * Update spatial_diffusion.Rmd * eliminate \(.) notation * Update explore_dsep.R --------- Co-authored-by: Jim Thorson <James.T.Thorson@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very silly pull request -
model$pathsinstead ofmodel$pathinread_modelcauses problems when adding missing variance parameters. All tests pass on my local machine, of course.