ci: improve binary release workflow #1
ItsusinnAnnotations
4 errors and 3 warnings
|
Compile (tuic-client, nightly-2024-03-01)
Canceling since a higher priority waiting request for 'binary-release-refs/heads/dev' exists
|
|
Compile (tuic-client, nightly-2024-03-01)
The operation was canceled.
|
|
Compile (tuic-server, nightly-2024-03-01)
Canceling since a higher priority waiting request for 'binary-release-refs/heads/dev' exists
|
|
Compile (tuic-server, nightly-2024-03-01)
The operation was canceled.
|
|
this `MutexGuard` is held across an `await` point:
tuic-client/src/connection/mod.rs#L148
warning: this `MutexGuard` is held across an `await` point
--> tuic-client/src/connection/mod.rs:148:32
|
148 | let new_conn = ENDPOINT.get().unwrap().lock().connect().await?;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: consider using an async-aware `Mutex` type or ensuring the `MutexGuard` is dropped before calling await
note: these are all the `await` points this lock is held through
--> tuic-client/src/connection/mod.rs:148:73
|
148 | let new_conn = ENDPOINT.get().unwrap().lock().connect().await?;
| ^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_lock
|
|
this `MutexGuard` is held across an `await` point:
tuic-client/src/connection/mod.rs#L131
warning: this `MutexGuard` is held across an `await` point
--> tuic-client/src/connection/mod.rs:131:13
|
131 | / ENDPOINT
132 | | .get()
133 | | .unwrap()
134 | | .lock()
| |_______________________^
|
= help: consider using an async-aware `Mutex` type or ensuring the `MutexGuard` is dropped before calling await
note: these are all the `await` points this lock is held through
--> tuic-client/src/connection/mod.rs:136:18
|
136 | .await
| ^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_lock
= note: `#[warn(clippy::await_holding_lock)]` on by default
|
|
you should consider adding a `Default` implementation for `Heartbeat`:
tuic/src/protocol/heartbeat.rs#L16
warning: you should consider adding a `Default` implementation for `Heartbeat`
--> tuic/src/protocol/heartbeat.rs:16:5
|
16 | / pub const fn new() -> Self {
17 | | Self
18 | | }
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
= note: `#[warn(clippy::new_without_default)]` on by default
help: try adding this
|
12 + impl Default for Heartbeat {
13 + fn default() -> Self {
14 + Self::new()
15 + }
16 + }
|
|