Added flatlands generator #845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sh0inx
commented
May 10, 2024
sh0inx
commented
- also added some logging about the generator type to ensure that server admins know what the correct enum values are
- also added some logging about the generator type to ensure that server admins know what the correct enum values are
Looks like you are missing an import or something? |
|
tbh i might be lol, let me fix it rq |
PeachesMLG
approved these changes
May 10, 2024
PeachesMLG
added a commit
that referenced
this pull request
Dec 28, 2024
* implementing the ocean generator * Cleanup * Updated Generators updated generators to allow server owners to set the default biome and whether they'd like their oceans to be decorated or not (includes ores, deposits, and geodes, no caves) * Update OceanGenerator.java cleaned up some residual das code * fixed the generator! uh so we basically create a duplicate of the world on first generation of an island that will then be used to copy and paste the terrain under the islands the first generation is slow because it has to create the worlds, but once this is done its exactly like the deleting blocks method except in reverse * refactored world generation to createWorld() - moved the cache world creation to the create world method so that the plugin does not lag on island creation - changed setting to GeneratorType enum - added vanilla generation option (takes advantage of null chunk generator) - deletes and regenerates cache world on bad seed comparison so that the cache world matches even on generator change * added generator type logging * Updated calls to regenerateTerrain to use .join() - moved the check for if the generator is a terrain generator to the methods that call regenerateTerrain * das suggested we format the enum differently so we did Co-authored-by: Daniel Scherf <35780068+dlsf@users.noreply.github.com> * Added flatlands generator (#845) * Added flatlands generator - also added some logging about the generator type to ensure that server admins know what the correct enum values are * forgot to import arrays, silly me * added a more explicit comment * made the delete world method a lil nicer (ty das) Co-authored-by: Daniel Scherf <35780068+dlsf@users.noreply.github.com> * removed generateChunkData * reverted deleteWorld method overhaul * remove imports * Re-implemented ChunkData method, cleaned up cache world creation * Removed shouldGenerateDecorations methods (temporarily) * Update IridiumSkyblock.java plugin would incorrectly report invalid generator type for VOID because i didnt add the case for void, so it would default * Fix imports --------- Co-authored-by: Shyanne <randomgirlisweird@gmail.com> Co-authored-by: Daniel Scherf <35780068+dlsf@users.noreply.github.com> Co-authored-by: Daniel Scherf <munita.gavai@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.