Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates scripts for gh #384

Conversation

TomKovac
Copy link
Collaborator

@TomKovac TomKovac commented Feb 13, 2025

This pull request includes several updates to various PowerShell scripts to enhance functionality and improve error handling. The most important changes include the addition of parameters, improved error messages, and enhanced script logic for handling GitHub issues and branches.

Enhancements to issue and branch management:

  • scripts/_change_state.ps1: Added parameters and logic to handle issue state transitions in GitHub projects using GraphQL. This includes fetching project IDs, validating column names, and moving issue cards between columns.
  • scripts/_create_issue_branch.ps1: Introduced a new parameter doNotCheckOldColumnName, added logic to ensure the script is run from the dev branch with no uncommitted changes, and integrated _change_state.ps1 to update issue states. [1] [2]

Error handling and validation improvements:

  • scripts/create_new_issue.ps1: Added input validation for issue title and body, ensuring they are not empty, and updated the script to call _create_issue_branch.ps1 with the new parameter. [1] [2]
  • scripts/ready_for_review.ps1: Added checks to ensure the working tree is clean before marking a branch as ready for review, and integrated _change_state.ps1 to update issue states accordingly.

Additional script enhancements:

closes #383

@TomKovac TomKovac self-assigned this Feb 13, 2025
@TomKovac TomKovac requested review from PTKu and kuh0005 February 13, 2025 18:43
@TomKovac TomKovac marked this pull request as ready for review February 13, 2025 18:43
@PTKu
Copy link
Contributor

PTKu commented Feb 13, 2025

I would not pollute ixc with this.
We can use semantic model for that in a dedicated tooling, as we do for the documentation and resx compilers.

Copy link
Contributor

@PTKu PTKu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep the modifications to the scripts as it is, but remove the modifications to Program.cs.

@PTKu PTKu self-requested a review February 14, 2025 15:05
@PTKu PTKu changed the title ixc should export also the number of stations, components, datamanagers etc. to help to choose the PLC with sufficient computing and communication power Updates scripts for gh Feb 14, 2025
@PTKu PTKu merged commit 83a7f45 into dev Feb 14, 2025
2 checks passed
@PTKu PTKu deleted the 383-ixc-should-export-also-the-number-of-stations-components-datamanagers-etc-to-help-to-choose-the-plc-with-sufficient-computing-and-communication-power branch February 14, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants