Merge pull request #365 from Inxton/364-when-writing-a-string-to-the-…

…plc-and-length-more-than-declared-exception-occurs When writing a string to the PLC and length more than declared exception occurs
Inxton · Jan 24, 2025 · b77dbc1 · b77dbc1
2 parents e93cb05 + 44b494f
commit b77dbc1
Show file tree

Hide file tree

Showing 28 changed files with 176 additions and 4 deletions.
diff --git a/src/AXSharp.compiler/src/AXSharp.Cs.Compiler/Onliner/CsOnlinerConstructorBuilder.cs b/src/AXSharp.compiler/src/AXSharp.Cs.Compiler/Onliner/CsOnlinerConstructorBuilder.cs
@@ -360,6 +360,8 @@ private void AddMemberInitialization(IStringTypeDeclaration type, IStorageDeclar
         AddToSource($"{field.Name}");
         AddToSource($"= @Connector.ConnectorAdapter.AdapterFactory.Create{IecToAdapterExtensions.ToAdapterType(type)}");
         AddToSource($"(this, \"{field.GetAttributeNameValue(field.Name)}\", \"{field.Name}\");");
+        AddToSource($"{field.Name}.Capacity = {type.Capacity};");
+
     }
 
     // We get warning here about unused method, it is false positive, but we will need to investigate further the object hierarchy.

diff --git a/.../AXSharp.Compiler.CsTests/samples/units/expected/ax/.g/Onliners/class_all_primitives.g.cs b/.../AXSharp.Compiler.CsTests/samples/units/expected/ax/.g/Onliners/class_all_primitives.g.cs
@@ -29,6 +29,8 @@ public partial class class_all_primitives : AXSharp.Connector.ITwinObject
     public OnlinerDateTime myDATE_AND_TIME { get; }
     public OnlinerString mySTRING { get; }
     public OnlinerWString myWSTRING { get; }
+    public OnlinerString mySTRING_25 { get; }
+    public OnlinerWString myWSTRING_55 { get; }
 
     partial void PreConstruct(AXSharp.Connector.ITwinObject parent, string readableTail, string symbolTail);
     partial void PostConstruct(AXSharp.Connector.ITwinObject parent, string readableTail, string symbolTail);
@@ -61,7 +63,13 @@ public class_all_primitives(AXSharp.Connector.ITwinObject parent, string readabl
         myTIME_OF_DAY = @Connector.ConnectorAdapter.AdapterFactory.CreateTIME_OF_DAY(this, "myTIME_OF_DAY", "myTIME_OF_DAY");
         myDATE_AND_TIME = @Connector.ConnectorAdapter.AdapterFactory.CreateDATE_AND_TIME(this, "myDATE_AND_TIME", "myDATE_AND_TIME");
         mySTRING = @Connector.ConnectorAdapter.AdapterFactory.CreateSTRING(this, "mySTRING", "mySTRING");
+        mySTRING.Capacity = 254;
         myWSTRING = @Connector.ConnectorAdapter.AdapterFactory.CreateWSTRING(this, "myWSTRING", "myWSTRING");
+        myWSTRING.Capacity = 254;
+        mySTRING_25 = @Connector.ConnectorAdapter.AdapterFactory.CreateSTRING(this, "mySTRING_25", "mySTRING_25");
+        mySTRING_25.Capacity = 25;
+        myWSTRING_55 = @Connector.ConnectorAdapter.AdapterFactory.CreateWSTRING(this, "myWSTRING_55", "myWSTRING_55");
+        myWSTRING_55.Capacity = 55;
         parent.AddChild(this);
         parent.AddKid(this);
         PostConstruct(parent, readableTail, symbolTail);
@@ -98,6 +106,8 @@ public async virtual Task<T> OnlineToPlain<T>()
         plain.myDATE_AND_TIME = myDATE_AND_TIME.LastValue;
         plain.mySTRING = mySTRING.LastValue;
         plain.myWSTRING = myWSTRING.LastValue;
+        plain.mySTRING_25 = mySTRING_25.LastValue;
+        plain.myWSTRING_55 = myWSTRING_55.LastValue;
         return plain;
     }
 
@@ -128,6 +138,8 @@ public async virtual Task<T> OnlineToPlain<T>()
         plain.myDATE_AND_TIME = myDATE_AND_TIME.LastValue;
         plain.mySTRING = mySTRING.LastValue;
         plain.myWSTRING = myWSTRING.LastValue;
+        plain.mySTRING_25 = mySTRING_25.LastValue;
+        plain.myWSTRING_55 = myWSTRING_55.LastValue;
         return plain;
     }
 
@@ -157,6 +169,8 @@ public async virtual Task<T> OnlineToPlain<T>()
         plain.myDATE_AND_TIME = myDATE_AND_TIME.LastValue;
         plain.mySTRING = mySTRING.LastValue;
         plain.myWSTRING = myWSTRING.LastValue;
+        plain.mySTRING_25 = mySTRING_25.LastValue;
+        plain.myWSTRING_55 = myWSTRING_55.LastValue;
         return plain;
     }
 
@@ -232,6 +246,12 @@ public async Task<IEnumerable<ITwinPrimitive>> PlainToOnlineAsync(global::Pocos.
 #pragma warning restore CS0612
 #pragma warning disable CS0612
         myWSTRING.LethargicWrite(plain.myWSTRING);
+#pragma warning restore CS0612
+#pragma warning disable CS0612
+        mySTRING_25.LethargicWrite(plain.mySTRING_25);
+#pragma warning restore CS0612
+#pragma warning disable CS0612
+        myWSTRING_55.LethargicWrite(plain.myWSTRING_55);
 #pragma warning restore CS0612
         return await this.WriteAsync<IgnoreOnPocoOperation>();
     }
@@ -305,6 +325,12 @@ public async Task _PlainToOnlineNoacAsync(global::Pocos.class_all_primitives pla
 #pragma warning restore CS0612
 #pragma warning disable CS0612
         myWSTRING.LethargicWrite(plain.myWSTRING);
+#pragma warning restore CS0612
+#pragma warning disable CS0612
+        mySTRING_25.LethargicWrite(plain.mySTRING_25);
+#pragma warning restore CS0612
+#pragma warning disable CS0612
+        myWSTRING_55.LethargicWrite(plain.myWSTRING_55);
 #pragma warning restore CS0612
     }
 
@@ -338,6 +364,8 @@ public async virtual Task<T> ShadowToPlain<T>()
         plain.myDATE_AND_TIME = myDATE_AND_TIME.Shadow;
         plain.mySTRING = mySTRING.Shadow;
         plain.myWSTRING = myWSTRING.Shadow;
+        plain.mySTRING_25 = mySTRING_25.Shadow;
+        plain.myWSTRING_55 = myWSTRING_55.Shadow;
         return plain;
     }
 
@@ -365,6 +393,8 @@ public async virtual Task<T> ShadowToPlain<T>()
         plain.myDATE_AND_TIME = myDATE_AND_TIME.Shadow;
         plain.mySTRING = mySTRING.Shadow;
         plain.myWSTRING = myWSTRING.Shadow;
+        plain.mySTRING_25 = mySTRING_25.Shadow;
+        plain.myWSTRING_55 = myWSTRING_55.Shadow;
         return plain;
     }
 
@@ -397,6 +427,8 @@ public async Task<IEnumerable<ITwinPrimitive>> PlainToShadowAsync(global::Pocos.
         myDATE_AND_TIME.Shadow = plain.myDATE_AND_TIME;
         mySTRING.Shadow = plain.mySTRING;
         myWSTRING.Shadow = plain.myWSTRING;
+        mySTRING_25.Shadow = plain.mySTRING_25;
+        myWSTRING_55.Shadow = plain.myWSTRING_55;
         return this.RetrievePrimitives();
     }
 
@@ -461,6 +493,10 @@ public async Task<bool> DetectsAnyChangeAsync(global::Pocos.class_all_primitives
                 somethingChanged = true;
             if (plain.myWSTRING != myWSTRING.LastValue)
                 somethingChanged = true;
+            if (plain.mySTRING_25 != mySTRING_25.LastValue)
+                somethingChanged = true;
+            if (plain.myWSTRING_55 != myWSTRING_55.LastValue)
+                somethingChanged = true;
             plain = latest;
             return somethingChanged;
         });

diff --git a/....Compiler.CsTests/samples/units/expected/ax/.g/Onliners/class_extended_by_known_type.g.cs b/....Compiler.CsTests/samples/units/expected/ax/.g/Onliners/class_extended_by_known_type.g.cs
@@ -156,6 +156,7 @@ public AbstractState(AXSharp.Connector.ITwinObject parent, string readableTail,
             PreConstruct(parent, readableTail, symbolTail);
             StateID = @Connector.ConnectorAdapter.AdapterFactory.CreateINT(this, "StateID", "StateID");
             StateName = @Connector.ConnectorAdapter.AdapterFactory.CreateSTRING(this, "StateName", "StateName");
+            StateName.Capacity = 254;
             parent.AddChild(this);
             parent.AddKid(this);
             PostConstruct(parent, readableTail, symbolTail);

diff --git a/....Compiler.CsTests/samples/units/expected/ax/.g/Onliners/class_with_primitive_members.g.cs b/....Compiler.CsTests/samples/units/expected/ax/.g/Onliners/class_with_primitive_members.g.cs
@@ -73,7 +73,9 @@ public ClassWithPrimitiveTypes(AXSharp.Connector.ITwinObject parent, string read
             myCHAR = @Connector.ConnectorAdapter.AdapterFactory.CreateCHAR(this, "myCHAR", "myCHAR");
             myWCHAR = @Connector.ConnectorAdapter.AdapterFactory.CreateWCHAR(this, "myWCHAR", "myWCHAR");
             mySTRING = @Connector.ConnectorAdapter.AdapterFactory.CreateSTRING(this, "mySTRING", "mySTRING");
+            mySTRING.Capacity = 254;
             myWSTRING = @Connector.ConnectorAdapter.AdapterFactory.CreateWSTRING(this, "myWSTRING", "myWSTRING");
+            myWSTRING.Capacity = 254;
             parent.AddChild(this);
             parent.AddKid(this);
             PostConstruct(parent, readableTail, symbolTail);

diff --git a/...XSharp.Compiler.CsTests/samples/units/expected/ax/.g/Onliners/compileromitsattribute.g.cs b/...XSharp.Compiler.CsTests/samples/units/expected/ax/.g/Onliners/compileromitsattribute.g.cs
@@ -245,6 +245,7 @@ public Complex(AXSharp.Connector.ITwinObject parent, string readableTail, string
             HumanReadable = AXSharp.Connector.Connector.CreateHumanReadable(parent.HumanReadable, readableTail);
             PreConstruct(parent, readableTail, symbolTail);
             HelloString = @Connector.ConnectorAdapter.AdapterFactory.CreateSTRING(this, "HelloString", "HelloString");
+            HelloString.Capacity = 254;
             Id = @Connector.ConnectorAdapter.AdapterFactory.CreateULINT(this, "Id", "Id");
             parent.AddChild(this);
             parent.AddKid(this);
@@ -960,6 +961,7 @@ public SomeClass(AXSharp.Connector.ITwinObject parent, string readableTail, stri
             HumanReadable = AXSharp.Connector.Connector.CreateHumanReadable(parent.HumanReadable, readableTail);
             PreConstruct(parent, readableTail, symbolTail);
             SomeClassVariable = @Connector.ConnectorAdapter.AdapterFactory.CreateSTRING(this, "SomeClassVariable", "SomeClassVariable");
+            SomeClassVariable.Capacity = 254;
             parent.AddChild(this);
             parent.AddKid(this);
             PostConstruct(parent, readableTail, symbolTail);
@@ -1864,6 +1866,7 @@ public Complex(AXSharp.Connector.ITwinObject parent, string readableTail, string
             HumanReadable = AXSharp.Connector.Connector.CreateHumanReadable(parent.HumanReadable, readableTail);
             PreConstruct(parent, readableTail, symbolTail);
             HelloString = @Connector.ConnectorAdapter.AdapterFactory.CreateSTRING(this, "HelloString", "HelloString");
+            HelloString.Capacity = 254;
             Id = @Connector.ConnectorAdapter.AdapterFactory.CreateULINT(this, "Id", "Id");
             parent.AddChild(this);
             parent.AddKid(this);

diff --git a/...r/tests/AXSharp.Compiler.CsTests/samples/units/expected/ax/.g/Onliners/configuration.g.cs b/...r/tests/AXSharp.Compiler.CsTests/samples/units/expected/ax/.g/Onliners/configuration.g.cs
@@ -72,7 +72,9 @@ public ComplexForConfig(AXSharp.Connector.ITwinObject parent, string readableTai
         myCHAR = @Connector.ConnectorAdapter.AdapterFactory.CreateCHAR(this, "myCHAR", "myCHAR");
         myWCHAR = @Connector.ConnectorAdapter.AdapterFactory.CreateWCHAR(this, "myWCHAR", "myWCHAR");
         mySTRING = @Connector.ConnectorAdapter.AdapterFactory.CreateSTRING(this, "mySTRING", "mySTRING");
+        mySTRING.Capacity = 254;
         myWSTRING = @Connector.ConnectorAdapter.AdapterFactory.CreateWSTRING(this, "myWSTRING", "myWSTRING");
+        myWSTRING.Capacity = 254;
         myMotor = new Motor(this, "myMotor", "myMotor");
         parent.AddChild(this);
         parent.AddKid(this);

diff --git a/...er/tests/AXSharp.Compiler.CsTests/samples/units/expected/ax/.g/Onliners/makereadonce.g.cs b/...er/tests/AXSharp.Compiler.CsTests/samples/units/expected/ax/.g/Onliners/makereadonce.g.cs
@@ -28,8 +28,10 @@ public MembersWithMakeReadOnce(AXSharp.Connector.ITwinObject parent, string read
             HumanReadable = AXSharp.Connector.Connector.CreateHumanReadable(parent.HumanReadable, readableTail);
             PreConstruct(parent, readableTail, symbolTail);
             makeReadOnceMember = @Connector.ConnectorAdapter.AdapterFactory.CreateSTRING(this, "makeReadOnceMember", "makeReadOnceMember");
+            makeReadOnceMember.Capacity = 254;
             makeReadOnceMember.MakeReadOnce();
             someOtherMember = @Connector.ConnectorAdapter.AdapterFactory.CreateSTRING(this, "someOtherMember", "someOtherMember");
+            someOtherMember.Capacity = 254;
             makeReadComplexMember = new makereadonce.ComplexMember(this, "makeReadComplexMember", "makeReadComplexMember");
             makeReadComplexMember.MakeReadOnce();
             someotherComplexMember = new makereadonce.ComplexMember(this, "someotherComplexMember", "someotherComplexMember");
@@ -299,7 +301,9 @@ public ComplexMember(AXSharp.Connector.ITwinObject parent, string readableTail,
             HumanReadable = AXSharp.Connector.Connector.CreateHumanReadable(parent.HumanReadable, readableTail);
             PreConstruct(parent, readableTail, symbolTail);
             someMember = @Connector.ConnectorAdapter.AdapterFactory.CreateSTRING(this, "someMember", "someMember");
+            someMember.Capacity = 254;
             someOtherMember = @Connector.ConnectorAdapter.AdapterFactory.CreateSTRING(this, "someOtherMember", "someOtherMember");
+            someOtherMember.Capacity = 254;
             parent.AddChild(this);
             parent.AddKid(this);
             PostConstruct(parent, readableTail, symbolTail);

diff --git a/...er/tests/AXSharp.Compiler.CsTests/samples/units/expected/ax/.g/Onliners/makereadonly.g.cs b/...er/tests/AXSharp.Compiler.CsTests/samples/units/expected/ax/.g/Onliners/makereadonly.g.cs
@@ -28,8 +28,10 @@ public MembersWithMakeReadOnly(AXSharp.Connector.ITwinObject parent, string read
             HumanReadable = AXSharp.Connector.Connector.CreateHumanReadable(parent.HumanReadable, readableTail);
             PreConstruct(parent, readableTail, symbolTail);
             makeReadOnceMember = @Connector.ConnectorAdapter.AdapterFactory.CreateSTRING(this, "makeReadOnceMember", "makeReadOnceMember");
+            makeReadOnceMember.Capacity = 254;
             makeReadOnceMember.MakeReadOnly();
             someOtherMember = @Connector.ConnectorAdapter.AdapterFactory.CreateSTRING(this, "someOtherMember", "someOtherMember");
+            someOtherMember.Capacity = 254;
             makeReadComplexMember = new makereadonly.ComplexMember(this, "makeReadComplexMember", "makeReadComplexMember");
             makeReadComplexMember.MakeReadOnly();
             someotherComplexMember = new makereadonly.ComplexMember(this, "someotherComplexMember", "someotherComplexMember");
@@ -299,7 +301,9 @@ public ComplexMember(AXSharp.Connector.ITwinObject parent, string readableTail,
             HumanReadable = AXSharp.Connector.Connector.CreateHumanReadable(parent.HumanReadable, readableTail);
             PreConstruct(parent, readableTail, symbolTail);
             someMember = @Connector.ConnectorAdapter.AdapterFactory.CreateSTRING(this, "someMember", "someMember");
+            someMember.Capacity = 254;
             someOtherMember = @Connector.ConnectorAdapter.AdapterFactory.CreateSTRING(this, "someOtherMember", "someOtherMember");
+            someOtherMember.Capacity = 254;
             parent.AddChild(this);
             parent.AddKid(this);
             PostConstruct(parent, readableTail, symbolTail);

diff --git a/...p.compiler/tests/AXSharp.Compiler.CsTests/samples/units/expected/ax/.g/Onliners/misc.g.cs b/...p.compiler/tests/AXSharp.Compiler.CsTests/samples/units/expected/ax/.g/Onliners/misc.g.cs
@@ -508,6 +508,7 @@ public SomeClass(AXSharp.Connector.ITwinObject parent, string readableTail, stri
             HumanReadable = AXSharp.Connector.Connector.CreateHumanReadable(parent.HumanReadable, readableTail);
             PreConstruct(parent, readableTail, symbolTail);
             SomeClassVariable = @Connector.ConnectorAdapter.AdapterFactory.CreateSTRING(this, "SomeClassVariable", "SomeClassVariable");
+            SomeClassVariable.Capacity = 254;
             parent.AddChild(this);
             parent.AddKid(this);
             PostConstruct(parent, readableTail, symbolTail);
@@ -1412,6 +1413,7 @@ public Complex(AXSharp.Connector.ITwinObject parent, string readableTail, string
             HumanReadable = AXSharp.Connector.Connector.CreateHumanReadable(parent.HumanReadable, readableTail);
             PreConstruct(parent, readableTail, symbolTail);
             HelloString = @Connector.ConnectorAdapter.AdapterFactory.CreateSTRING(this, "HelloString", "HelloString");
+            HelloString.Capacity = 254;
             Id = @Connector.ConnectorAdapter.AdapterFactory.CreateULINT(this, "Id", "Id");
             parent.AddChild(this);
             parent.AddKid(this);

diff --git a/...rp.Compiler.CsTests/samples/units/expected/ax/.g/Onliners/types_with_name_attributes.g.cs b/...rp.Compiler.CsTests/samples/units/expected/ax/.g/Onliners/types_with_name_attributes.g.cs
@@ -471,6 +471,7 @@ public NoAccessModifierClass(AXSharp.Connector.ITwinObject parent, string readab
             HumanReadable = AXSharp.Connector.Connector.CreateHumanReadable(parent.HumanReadable, readableTail);
             PreConstruct(parent, readableTail, symbolTail);
             SomeClassVariable = @Connector.ConnectorAdapter.AdapterFactory.CreateSTRING(this, "SomeClassVariable", "SomeClassVariable");
+            SomeClassVariable.Capacity = 254;
             parent.AddChild(this);
             parent.AddKid(this);
             PostConstruct(parent, readableTail, symbolTail);

diff --git a/...ests/AXSharp.Compiler.CsTests/samples/units/expected/ax/.g/POCO/class_all_primitives.g.cs b/...ests/AXSharp.Compiler.CsTests/samples/units/expected/ax/.g/POCO/class_all_primitives.g.cs
@@ -32,5 +32,7 @@ public class_all_primitives()
         public DateTime myDATE_AND_TIME { get; set; } = new DateTime(1970, 1, 1);
         public string mySTRING { get; set; } = string.Empty;
         public string myWSTRING { get; set; } = string.Empty;
+        public string mySTRING_25 { get; set; } = string.Empty;
+        public string myWSTRING_55 { get; set; } = string.Empty;
     }
 }
diff --git a/src/AXSharp.compiler/tests/AXSharp.Compiler.CsTests/samples/units/expected/ax/units.csproj b/src/AXSharp.compiler/tests/AXSharp.Compiler.CsTests/samples/units/expected/ax/units.csproj
@@ -0,0 +1,21 @@
+<Project Sdk="Microsoft.NET.Sdk">
+	<PropertyGroup>
+		<TargetFrameworks>net9.0;net8.0</TargetFrameworks>
+		<ImplicitUsings>enable</ImplicitUsings>
+		<Nullable>enable</Nullable>
+	</PropertyGroup>
+
+	<ItemGroup>
+		<PackageReference Include="AXSharp.Abstractions" Version="0.22.0-364-when-writing-a-string-to-the-plc-and-length-more-than-declared-exception-occurs.304" />
+		<PackageReference Include="AXSharp.Connector" Version="0.22.0-364-when-writing-a-string-to-the-plc-and-length-more-than-declared-exception-occurs.304" />
+	</ItemGroup>
+
+	<ItemGroup>
+    	<Compile Include=".g\**" />
+  	</ItemGroup>
+
+	<ItemGroup>
+		<Folder Include=".meta\" />
+		<Content Include=".meta\**" />
+	</ItemGroup>
+</Project>