Address issues with flakiness of DRep Activity test #5830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palas
force-pushed
the
ci/debug-drep-activity
branch
6 times, most recently
from
63820ca to
42cd402
Compare
carbolymer
reviewed
May 9, 2024
carbolymer
reviewed
May 9, 2024
carbolymer
reviewed
May 9, 2024
carbolymer
reviewed
May 9, 2024
cardano-testnet/test/cardano-testnet-test/Cardano/Testnet/Test/Gov/DRepActivity.hs
Outdated
Show resolved
Hide resolved
cardano-testnet/test/cardano-testnet-test/Cardano/Testnet/Test/Gov/DRepActivity.hs
Outdated
Show resolved
Hide resolved
cardano-testnet/test/cardano-testnet-test/Cardano/Testnet/Test/Gov/DRepActivity.hs
Outdated
Show resolved
Hide resolved
newhoggy
reviewed
May 9, 2024
Jimbo4350
requested changes
May 9, 2024
palas
force-pushed
the
ci/debug-drep-activity
branch
4 times, most recently
from
12a568e to
2244677
Compare
newhoggy
reviewed
May 10, 2024
newhoggy
reviewed
May 10, 2024
carbolymer
approved these changes
May 10, 2024
cardano-testnet/test/cardano-testnet-test/Cardano/Testnet/Test/Gov/DRepActivity.hs
Show resolved
Hide resolved
Jimbo4350
previously requested changes
May 10, 2024
cardano-testnet/test/cardano-testnet-test/Cardano/Testnet/Test/Gov/DRepActivity.hs
Show resolved
Hide resolved
cardano-testnet/test/cardano-testnet-test/Cardano/Testnet/Test/Gov/DRepActivity.hs
Outdated
Show resolved
Hide resolved
9 tasks
palas
force-pushed
the
ci/debug-drep-activity
branch
from
aa8a4f0 to
a3c589c
Compare
Co-authored-by: Mateusz Galazyn <228866+carbolymer@users.noreply.github.com>
Co-authored-by: Mateusz Galazyn <228866+carbolymer@users.noreply.github.com>
…osal`, and `voteChangeProposal`
palas
force-pushed
the
ci/debug-drep-activity
branch
from
a3c589c to
5935b8e
Compare
palas
force-pushed
the
ci/debug-drep-activity
branch
from
5935b8e to
88c6839
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DRep Activity test was disabled because it was failing often. This PR aims to address this issues and reenable it.
It seems the flakiness was due to two things:
foldEpochStaterepeatedly, I am now polling withgetEpochStateinstead.100slots per epoch, I am now using200.I will remove the last two commits when it gets approved and before merging.
Checklist
See Runnings tests for more details
CHANGELOG.mdfor affected package.cabalfiles are updatedhlint. See.github/workflows/check-hlint.ymlto get thehlintversionstylish-haskell. See.github/workflows/stylish-haskell.ymlto get thestylish-haskellversionghc-8.10.7andghc-9.2.7