Improve offchain #1860
Merged
Improve offchain #1860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs testing |
sgillespie
reviewed
Sep 25, 2024
| httpGetOffChainVoteData gateways vurl metaHash anchorType = do | ||
| case useIpfsGatewayMaybe vurl gateways of | ||
| Nothing -> httpGetOffChainVoteDataSingle vurl metaHash anchorType | ||
| Just [] -> left $ OCFErrNoIpfsGateway (OffChainVoteUrl vurl) |
There was a problem hiding this comment.
Why not just make this a NonEmpty?
There was a problem hiding this comment.
I might be reading this wrong, but it looks to me like having empty gateways is an error here. If that's correct, can we make gateways a nonempty? That would push the check up to a config check and make everywhere else a safer call
There was a problem hiding this comment.
It's an error that doesn't bubble up. It ends up in the off_chain_vote_fetch_error table.
The user has to specify a list of gateaways, if he wants to support ipfs links
sgillespie
reviewed
Sep 25, 2024
| @@ -103,6 +104,7 @@ syncNodeConfig loggingCfg = | |||
| <*> triggerHardFork | |||
| <*> triggerHardFork | |||
| <*> syncInsertOptions | |||
| <*> pure [] | |||
There was a problem hiding this comment.
It would probably be useful to generate ipfs_gateway values
There was a problem hiding this comment.
Any suggestions for a generator to be used here? Not bvery familiar with these tests
Cmdv
previously approved these changes
Sep 26, 2024
| @@ -112,6 +112,7 @@ classifyFetchError tf fe = | |||
| OCFErrIOException {} -> tf {tfIOException = tfIOException tf + 1} | |||
| OCFErrTimeout {} -> tf {tfTimeout = tfTimeout tf + 1} | |||
| OCFErrConnectionFailure {} -> tf {tfConnectionFailure = tfConnectionFailure tf + 1} | |||
| _ -> tf | |||
There was a problem hiding this comment.
hlint always complains about _ -> that's the only reason I've been doing _otherwise 🤷
|
After testing this on mainnet
|
kderme
force-pushed
the
kderme/improve-offchain
branch
2 times, most recently
from
774396d to
27f8621
Compare
kderme
force-pushed
the
kderme/improve-offchain
branch
from
27f8621 to
19cc86e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add your description here, if it fixes a particular issue please provide a link to the issue.
Checklist
fourmoluon version 0.10.1.0 (which can be run withscripts/fourmolize.sh)Migrations
If there is a breaking change, especially a big one, please add a justification here. Please elaborate
more what the migration achieves, what it cannot achieve or why a migration is not possible.