CI: run actionlint #740
Merged
CI: run actionlint #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smelc
force-pushed
the
smelc/ci-actionlint
branch
2 times, most recently
from
e92184b to
d7ee1fb
Compare
smelc
force-pushed
the
smelc/ci-actionlint
branch
from
d7ee1fb to
7c74ffd
Compare
smelc
commented
Apr 25, 2024
| @@ -124,10 +124,6 @@ jobs: | |||
| - name: Build Haddock documentation 🔧 | |||
| run: ./.github/bin/haddocks.sh ./haddocks true | |||
|
|
|||
| - name: View HTML files | |||
| run: | | |||
| find "dist-newstyle/build" -name '*.html' | xargs grep html | |||
There was a problem hiding this comment.
This had no effect besides outputting a big number of lines to the pipeline's log.
carbolymer
reviewed
Apr 25, 2024
| @@ -93,9 +93,9 @@ | |||
| ({pkgs, ...}: { | |||
| packages.cardano-cli.configureFlags = [ "--ghc-option=-Werror" ] ++ gitRevFlag; | |||
| packages.cardano-cli.components.tests.cardano-cli-test.build-tools = | |||
| with pkgs.buildPackages; [ jq coreutils shellcheck ]; | |||
| with pkgs.buildPackages; [ jq coreutils ]; | |||
There was a problem hiding this comment.
why do we need jq for cli tests? 🤔 I have also doubts about coreutils there.
There was a problem hiding this comment.
I'll look into this next 👍
carbolymer
reviewed
Apr 25, 2024
| @@ -0,0 +1 @@ | |||
| .github/workflows/check-stylish-haskell.yml | |||
There was a problem hiding this comment.
What's wrong with this workflow now?
There was a problem hiding this comment.
@carbolymer> there a number of missing quotes I believe:
.github/workflows/check-stylish-haskell.yml:40:7: shellcheck reported issue in this script: SC2086:info:7:66: Double quote to prevent globbing and word splitting [shellcheck]
|
40 | run: |
| ^~~~
.github/workflows/check-stylish-haskell.yml:52:7: shellcheck reported issue in this script: SC2086:info:6:22: Double quote to prevent globbing and word splitting [shellcheck]
|
52 | run: |
| ^~~~
.github/workflows/check-stylish-haskell.yml:52:7: shellcheck reported issue in this script: SC2086:info:9:26: Double quote to prevent globbing and word splitting [shellcheck]
|
52 | run: |
| ^~~~
.github/workflows/check-stylish-haskell.yml:69:7: shellcheck reported issue in this script: SC2086:info:6:22: Double quote to prevent globbing and word splitting [shellcheck]
|
69 | run: |
| ^~~~
.github/workflows/check-stylish-haskell.yml:69:7: shellcheck reported issue in this script: SC2086:info:9:26: Double quote to prevent globbing and word splitting [shellcheck]
|
69 | run: |
| ^~~~
I didn't fix them in this PR, because in my experience, adding checks and fixing warnings in the same PR tend to make the PR harder to merge.
I can make fix them afterwards 👍
carbolymer
approved these changes
Apr 25, 2024
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
actionlint is the defacto checker for GHA workflow files. In my experience, it is quite good and catches a number of mistakes.
How to trust this PR
Checklist