Remove use of script witness files in withdrawal scripts #1056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jimbo4350
force-pushed
the
jordan/remove-use-of-ScriptWitnessFiles-in-withdrawal-scripts
branch
3 times, most recently
from
c820df8 to
c7e71ed
Compare
Jimbo4350
requested review from
newhoggy,
carbolymer,
smelc,
palas,
kevinhammond and
disassembler
as code owners
Jimbo4350
force-pushed
the
jordan/remove-use-of-ScriptWitnessFiles-in-withdrawal-scripts
branch
2 times, most recently
from
e5b6d88 to
7b20f90
Compare
carbolymer
approved these changes
Feb 7, 2025
| <*> plutusP prefix PlutusScriptV3 "v3" | ||
| <*> pScriptRedeemerOrFile (prefix ++ "reference-tx-in") | ||
| <*> ( case autoBalanceExecUnits of | ||
| AutoBalance -> pure (ExecutionUnits 0 0) |
There was a problem hiding this comment.
It would be nice to have this execution units default value in one place, instead of being copied multiple times.
There was a problem hiding this comment.
Yep we will do an audit of all the cli parsers. It's still convoluted.
…I.EraBased.Script.Withdrawal.Types These modules contain functionality to aid reading withdrawal script witnesses from the cli command line
throughout transaction building code
Jimbo4350
force-pushed
the
jordan/remove-use-of-ScriptWitnessFiles-in-withdrawal-scripts
branch
from
7b20f90 to
e51cc89
Compare
Jimbo4350
deleted the
jordan/remove-use-of-ScriptWitnessFiles-in-withdrawal-scripts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1047
Changelog
Context
Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.
How to trust this PR
Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.
Checklist