Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it build with ghc 9.12 #768

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Make it build with ghc 9.12 #768

wants to merge 4 commits into from
+37 −15

Conversation

erikd
Copy link
Contributor

@erikd erikd commented Mar 3, 2025

Changelog

- description: Make it build with ghc 9.12
# uncomment types applicable to the change:
  type:
    - maintenance    # not directly related to the code

Context

How to trust this PR

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

erikd added 3 commits March 3, 2025 11:29
@erikd
Remove derived Typeable instances
5b60129 
No longer needed. GHC has been deriving this typeclass for some time
and ghc-9.12 now warns about if being redundant.
@erikd
Make it build with ghc-9.12
cb8e394
@erikd
CI: Add ghc-9.12 to the build matrix
c222dce
@erikd erikd changed the title Maye it build with ghc 9.12 Make it build with ghc 9.12 Mar 3, 2025
@carbolymer
Copy link
Contributor

Nice. There are nix errors here though. Maybe haskellNix needs to be bumped for that as well? We have it pinned in the input: https://github.com/IntersectMBO/cardano-api/blob/master/flake.nix#L10

@carbolymer carbolymer force-pushed the erikd/ghc-9.12 branch 2 times, most recently from 55435cb to d2cd880 Compare March 3, 2025 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jimbo4350 Jimbo4350 Awaiting requested review from Jimbo4350 Jimbo4350 is a code owner

@newhoggy newhoggy Awaiting requested review from newhoggy newhoggy is a code owner

@carbolymer carbolymer Awaiting requested review from carbolymer carbolymer is a code owner

@smelc smelc Awaiting requested review from smelc smelc is a code owner

@palas palas Awaiting requested review from palas palas is a code owner

@dcoutts dcoutts Awaiting requested review from dcoutts dcoutts is a code owner

@kevinhammond kevinhammond Awaiting requested review from kevinhammond kevinhammond is a code owner

@CarlosLopezDeLara CarlosLopezDeLara Awaiting requested review from CarlosLopezDeLara CarlosLopezDeLara is a code owner

@disassembler disassembler Awaiting requested review from disassembler disassembler is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erikd @carbolymer