Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing gov action on balance transaction #765

Merged
merged 1 commit into from
Feb 27, 2025
Merged

Conversation

palas
Copy link
Contributor

@palas palas commented Feb 26, 2025

Changelog

- description: |
    Fixed a bug that caused balancing algorithm to drop unwitnessed government actions
  type:
  - bugfix

Context

This PR:

How to trust this PR

Check the test. You can verify that it fails if applied before the fix.
Check that the code style is correct, that the changes make sense, and the new code doesn't introduce any new bugs.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@palas palas added the bug Something isn't working label Feb 26, 2025
@palas palas self-assigned this Feb 26, 2025
@palas palas requested a review from disassembler as a code owner February 26, 2025 14:17
@palas palas requested a review from carbolymer February 27, 2025 12:52
Copy link
Contributor

@carbolymer carbolymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work. I'm leaving approval to @Jimbo4350

Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👍 . Squash the commits.

@carbolymer carbolymer self-requested a review February 27, 2025 15:51
@palas palas force-pushed the fix-missing-gov-action branch from 5625e5f to f4bb759 Compare February 27, 2025 18:39
@palas palas dismissed carbolymer’s stale review February 27, 2025 18:44

Already gave a positive review conditional to Jordan's approval after the changes were requested and addressed,, and I addressed all new issues reported in all reviews. So I am interpreting it as a tacit approval

@palas palas enabled auto-merge February 27, 2025 18:48
@palas palas added this pull request to the merge queue Feb 27, 2025
Merged via the queue into master with commit a69f7c2 Feb 27, 2025
29 checks passed
@palas palas deleted the fix-missing-gov-action branch February 27, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Governance actions silently stripped from transaction
3 participants