-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing gov action on balance transaction #765
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice work. I'm leaving approval to @Jimbo4350
cardano-api/test/cardano-api-test/Test/Cardano/Api/Transaction/Autobalance.hs
Outdated
Show resolved
Hide resolved
cardano-api/test/cardano-api-test/Test/Cardano/Api/Transaction/Autobalance.hs
Outdated
Show resolved
Hide resolved
cardano-api/test/cardano-api-test/Test/Cardano/Api/Transaction/Autobalance.hs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 👍 . Squash the commits.
5625e5f
to
f4bb759
Compare
Already gave a positive review conditional to Jordan's approval after the changes were requested and addressed,, and I addressed all new issues reported in all reviews. So I am interpreting it as a tacit approval
Changelog
Context
This PR:
cardano-api
level if such a problem occurs againHow to trust this PR
Check the test. You can verify that it fails if applied before the fix.
Check that the code style is correct, that the changes make sense, and the new code doesn't introduce any new bugs.
Checklist