Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stylish haskell. Use only fourmolu for formatting. #756

Merged
merged 3 commits into from
Feb 18, 2025

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented Feb 18, 2025

Changelog

- description: |
    Remove stylish haskell. Use only fourmolu for formatting.
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
   - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

This PR changes our formatting method to just use fourmolu instead of fourmolu + stylish-haskell. Import grouping settings were copied 1-1 from stylsh settings.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@carbolymer carbolymer self-assigned this Feb 18, 2025
@carbolymer carbolymer force-pushed the mgalazyn/chore/remove-stylish-haskell branch from 6075815 to 2ea79c0 Compare February 18, 2025 12:01
@carbolymer carbolymer marked this pull request as ready for review February 18, 2025 12:03
@@ -91,7 +90,7 @@ for file in $files; do
fi
done

for tool in stylish-haskell fourmolu
for tool in fourmolu
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could take this occasion to remove this loop that rolls only once now, but fine to leave it.

@@ -2,3 +2,4 @@ e28fadbebc18b87991f84af72d8611393ae8875a
b76f949e815990545371530a466b16f691a3aa98
73fd9122f78282b1db7f6884b3bc23fb29f3e67f
7634a9e8235050a55e5e3022a22a550aa3ade06e
1bb9b9baf0aa9bf610df7fb8fcad193563469eb3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@carbolymer carbolymer added this pull request to the merge queue Feb 18, 2025
Merged via the queue into master with commit 7b54ab3 Feb 18, 2025
31 checks passed
@carbolymer carbolymer deleted the mgalazyn/chore/remove-stylish-haskell branch February 18, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants