-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove stylish haskell. Use only fourmolu for formatting. #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6075815
to
2ea79c0
Compare
Jimbo4350
approved these changes
Feb 18, 2025
smelc
approved these changes
Feb 18, 2025
@@ -91,7 +90,7 @@ for file in $files; do | |||
fi | |||
done | |||
|
|||
for tool in stylish-haskell fourmolu | |||
for tool in fourmolu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could take this occasion to remove this loop that rolls only once now, but fine to leave it.
smelc
reviewed
Feb 18, 2025
@@ -2,3 +2,4 @@ e28fadbebc18b87991f84af72d8611393ae8875a | |||
b76f949e815990545371530a466b16f691a3aa98 | |||
73fd9122f78282b1db7f6884b3bc23fb29f3e67f | |||
7634a9e8235050a55e5e3022a22a550aa3ade06e | |||
1bb9b9baf0aa9bf610df7fb8fcad193563469eb3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
This PR changes our formatting method to just use fourmolu instead of fourmolu + stylish-haskell. Import grouping settings were copied 1-1 from stylsh settings.
Checklist