Match Genius paths #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was only used to validated paths passed as query parameters. Now that we match Genius URLs, it's no longer needed
Insprill
force-pushed
the
feature/genius-paths
branch
from
fd527a2 to
5c4b8a0
Compare
Insprill
force-pushed
the
feature/genius-paths
branch
from
5c4b8a0 to
bfd1b09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we have our own schema for paths, with Genius paths being passed in query parameters. This makes it complicated to set automatic redirects from Genius to Intellectual and adds unnecessary complexity to the code.
This will need some testing to ensure that there are no edge cases that break the links and that no links were missed.
We also need a way to return a proper 404 page, since the lyric pattern now matches all paths. We might be able to only match paths that end in-lyrics, or we'll have to bail and return our own 404 if genius returns a 404.We should also try to coordinate the release of this with LibRedirect to minimize the damage from this.