Compat with 1.21.4 #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KealJones
commented
Mar 1, 2025
| } else | ||
| return false; | ||
| } | ||
|
|
||
| public static boolean checkFallFlyingIgnoreGround(ClientPlayerEntity player) { | ||
| if (!player.isTouchingWater() && !player.hasStatusEffect(StatusEffects.LEVITATION)) { | ||
| var itemStack = player.getEquippedStack(EquipmentSlot.CHEST); | ||
| if (itemStack.isOf(Items.ELYTRA) && ElytraItem.isUsable(itemStack)) { |
There was a problem hiding this comment.
ElytraItem is gone I didn't try hard to find a replacement for the ElytraItem.isUsable call removing it seemed fine enough.
KealJones
commented
Mar 1, 2025
| @@ -29,16 +29,16 @@ private ClientPlayerEntity player() { | |||
| private boolean awaitingElytra = false; | |||
|
|
|||
| @SuppressWarnings("ConstantConditions") | |||
| @Inject(method = "tickFallFlying", at = @At("TAIL")) | |||
| @Inject(method = "tickMovement", at = @At("TAIL")) | |||
There was a problem hiding this comment.
The is a tickGliding that replaced tickFallFlying but it doesn't work at all as you never get a gliding tick that would have isGliding as false. So I opted for tickMovement which seems to work but is obviously far less efficient.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get compatibility with 1.21.4. It has a new
Glidingmechanic that replacesFallFlyingand some other basic api changes but overall the logic is mostly the same. I left some comments in this PR for a few areas.It seems that my changes are slightly less efficient and don't work with Meteor's ElytraFly "bounce" mode but for casual play it works perfectly well... It works better on a server than in single player because of the addition of minor lag on servers, I assume. Something about the last tick before hitting the ground id think.
I am by no means an expert in fabric modding or java so anyone that can figure it out feel free to branch off this or do your own thing. <3