Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install local deps into container #359

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Install local deps into container #359

wants to merge 3 commits into from

Conversation

jamesturner246
Copy link
Contributor

@jamesturner246 jamesturner246 commented Feb 20, 2025

Description

Install local versions of drunc and druncschema into containers in editable mode, to enable developing and testing with the UI.

It seems like docker really really doesn't like this, so we should probably revisit. I don't know a cleaner way.

The repos are searched at DRUNC_LOCAL_DEPS, so make sure they're cloned to the right place.
This defaults to the current directory from which install_local_deps.sh is run, if DRUNC_LOCAL_DEPS is unset.

Then, with the compose up, run the following to install the repos editable inside the containers:

./scripts/install_local_deps.sh

Fixes #358.

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • All tests pass (eg. python -m pytest)
  • The documentation builds and looks OK (eg. python -m sphinx -b html docs docs/build)
  • Pre-commit hooks run successfully (eg. pre-commit run --all-files)

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added or an issue has been opened to tackle that in the future. (Indicate issue here: # (issue))

@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.50%. Comparing base (7053ce5) to head (3e2cb64).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #359   +/-   ##
=======================================
  Coverage   85.50%   85.50%           
=======================================
  Files          45       45           
  Lines         676      676           
=======================================
  Hits          578      578           
  Misses         98       98           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

drunc/druncschema devel container
3 participants