-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bulk operations for processes #101
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #101 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 43 43
=========================================
Hits 43 43 ☔ View full report in Codecov by Sentry. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff. A few tweaks and a question about why the restart command is different.
for uuid_ in uuids_: | ||
query = ProcessQuery(uuids=[uuid_]) | ||
await pmd.restart(query) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this different logic here? It makes things rather awkward and I'd be tempted to stick with the previous implementation, particularly if we take out the awaits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pmd.restart
do not work with more than one uuid
at the same time, so this one needs a loop. Where we put the loop, I don't mind.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff. Thanks for this.
That functionality is meant to be implemented in #87, not here. |
Ah, I seem No worries. 👍 |
Description
This PR remove the per-process operations and add checkboxes and buttons such that the operations can be triggered for multiple processes at once. Asa bonus, the code has been simplified significantly.
Fixes #86
Type of change
Key checklist
python -m pytest
)python -m sphinx -b html docs docs/build
)pre-commit run --all-files
)Further checks