Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(list): add selected item colors #391

Merged
merged 4 commits into from
Feb 27, 2025

Conversation

simeonoff
Copy link
Contributor

No description provided.

@simeonoff simeonoff requested a review from SisIvanova February 27, 2025 08:58
@@ -237,9 +275,9 @@ $fluent-list: extend(
/// @prop {Map} header-background [contrast-color: ('gray', 900)] - The list header background color.
/// @prop {Map} item-background [contrast-color: ('gray', 900)] - The list item background color.
/// @prop {Map} item-text-color [color: ('gray', 900)] - The list item text color.
/// @prop {Map} item-text-color-hover [color: ('gray', 900)] - The list item text color.
/// @prop {Map} item-text-color-hover [color: ('gray', 900)] - The list item text color on hover.
/// @prop {Map} item-text-color-active [color: ('gray', 900)] - The active list item text color.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also update the item-text-color-selected here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SisIvanova Done.

@simeonoff simeonoff added this pull request to the merge queue Feb 27, 2025
Merged via the queue into master with commit 2ccea11 Feb 27, 2025
1 check passed
@simeonoff simeonoff deleted the simeonoff/list-selected-colors branch February 27, 2025 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants