Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inputs): wrong colors in material theme #386

Merged
merged 6 commits into from
Feb 27, 2025

Conversation

SisIvanova
Copy link
Contributor

Closes #385

didimmova
didimmova previously approved these changes Feb 19, 2025
@SisIvanova SisIvanova changed the title fix(input): wrong colors in material dark theme fix(inputs): wrong colors in material theme Feb 19, 2025
@yradoeva

This comment was marked as resolved.

@yradoeva

This comment was marked as resolved.

@yradoeva
Copy link

Light mode

  1. Select & Combo, border style:
    Toggle button background color should be light grays.100 in all states
    Figma
Select a value Angular image

WebC image

Dark mode 2. Combo & Select - border style - focused state - the toggle button background color should be dark grays.100 (not grays.300) Figma Selected values

Angular image

WebC image

Regarding 1:
In order not to introduce additional variable for the toggle button background in border style, we are going to update the colors in the Figma design kit. Toggle button background in all states, except disabled, is going to be light grays.300 - the same as for box style. @sdimchevski

@yradoeva

This comment was marked as resolved.

@yradoeva

This comment was marked as resolved.

@simeonoff simeonoff merged commit 9cce63d into master Feb 27, 2025
1 check passed
@simeonoff simeonoff deleted the sivanova/dark-input-updates branch February 27, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Combo / Input / Select]: Background colors in some states don't match Figma (box design) in Material Dark
4 participants