Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tile-manager): add schemas #355

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Conversation

SisIvanova
Copy link
Contributor

@SisIvanova SisIvanova requested a review from simeonoff February 24, 2025 08:45
@yradoeva
Copy link

Drag & Drop (Slide)
Material Light

  • The blue placeholder should have a 1px border primary.500
    Figma
Screenshot 2025-02-28 at 9 35 36 WebC Tile 4 Title

Material Dark

  • The blue placeholder should have a 1px border primary.500

Fluent Light & Dark

  • The blue placeholder should have a 1px border primary.500

Bootstrap Light & Dark

  • The blue placeholder should have a 1px border primary.500

Indigo Light / Dark

  • The placeholder should have a 1px border primary.500 / primary.300

@yradoeva
Copy link

After discussion in the UX design team, we decided that the resize indicators color and the border of the tile while in resizeMode: hover or resizeMode: always need to be updated for better visibility. The new colors will be the same for tile border and indicators and will be as the border color of the placeholder element, meaning:
primary.500 for all themes light and dark mode, except for Indigo dark - primary.300.

Hover state, when the resizing is off, is not changed.

I am currently updating the design handoff and I'll let you know when it's ready.

Below are the changed tiles:
image

@yradoeva
Copy link

Tile resizing - all themes, light and dark mode
The original tile being resized (the one that stays at place) should not have an overlay with the color of the placeholder-background:

Figma - Material
Screenshot 2025-02-28 at 16 05 39

WebC - Material light
Screenshot 2025-02-28 at 15 57 39

.
Screenshot 2025-02-28 at 15 55 05

WebC - Material dark
Screenshot 2025-02-28 at 15 56 19

@yradoeva
Copy link

yradoeva commented Mar 4, 2025

Indigo Dark mode:
Tile - idle state - header - The icon color of the flat buttons in the header looks more transparent compared to the Figma design (screenshot: implementation is pasted over the design). When inspecting it, I see the color is right - white 80%, but for some reason it looks lighter.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tile Manager Component
3 participants