Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(badge): remove border width property #342

Merged
merged 2 commits into from
Oct 2, 2024
Merged

refactor(badge): remove border width property #342

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ad80cb
refactor(badge): remove border width property
SisIvanova Oct 1, 2024
7a65159
Merge branch 'master' into sivanova/update-badge-schema
simeonoff Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions sass/themes/schemas/components/light/_badge.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
/// @prop {Map} text-color [contrast-color: ('primary', 500)] - The text color used.
/// @prop {Map} border-color [color: ('gray', 50)] - The border color used.
/// @prop {Map} background-color [color: ('primary', 500)] - The background color used.
/// @prop {Number} border-width [0] - The border width of the badge component.
/// @prop {Number} elevation [1] - The elevation level, between 0-24, to be used for the badge shadow.
/// @prop {Number} border-radius [0] - The border radius used for badge.
/// @requires {Map} $default-elevation-badge
Expand Down Expand Up @@ -49,8 +48,6 @@ $light-badge: extend(
),
),

border-width: 0,

border-radius: 0,
)
);
Expand All @@ -67,14 +64,11 @@ $fluent-badge: $light-badge;

/// Generates a bootstrap badge schema.
/// @type {Map}
/// @prop {Number} border-width [1px] - The border width of the badge component.
/// @prop {Number} border-radius [rem(4px)] - The border radius used for badge.
/// @requires {Map} $light-badge
$bootstrap-badge: extend(
$light-badge,
(
border-width: 1px,

border-radius: rem(4px),
)
);
Expand Down
Loading