Fix Spellbook Title and Refactored Code #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, would you mind taking a look at this fix? If you don't have interest in maintaining this anymore would you please add me as a contributor? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for the ancient teleports plugin, I've gone ahead and updated it so it works on the spellbook again. Some of the renaming choices have been updated too: Annakarl was Annakarl, Dareeyak was Forgotten Cemetery (but Arceuss has its own direct teleport to there so instead Crazy Archaeologist makes more sense).
New function to replace strings without json and implemented spell renaming with more current spellbook methods as taken from this built-in runelite plugin: https://github.com/runelite/runelite/blob/master/runelite-client/src/main/java/net/runelite/client/plugins/spellbook/SpellbookPlugin.java