Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liquid Liquid Extractor Example #89

Closed
wants to merge 94 commits into from

Conversation

JavalVyas2000
Copy link
Contributor

@JavalVyas2000 JavalVyas2000 commented Mar 13, 2024

Liquid Liquid Extractor Example

This PR is a comprehensive tutorial on how to create a unit model from scratch, including a property package and unit model. It also includes how to write the tests for both. This unit model also tackles two phases and has two inlet and outlet ports, thereby giving an example for the user to create a new unit model that has multiple phases with multiple ports for inlet and outlet.

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

📚 Documentation preview 📚: https://idaes-examples--89.org.readthedocs.build/en/89/

JavalVyas2000 and others added 30 commits July 10, 2023 10:36
This reverts commit 9a62890.
@andrewlee94
Copy link
Member

@JavalVyas2000 It looks like you deleted this branch and closed the PR. Was this intentional, and if so could you leave a note as to why?

@JavalVyas2000
Copy link
Contributor Author

Yes. I had deleted the branch as I mistakenly checked out of another branch and not main. This created 72 changes in the files as it also considered the previous PR changes as well. Thus to avoid this created a new branch and made a PR.

@ksbeattie
Copy link
Member

Replaced by #91

@ksbeattie ksbeattie added the Priority:Normal Normal Priority Issue or PR label Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:Normal Normal Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants