Skip to content

Commit

Permalink
Fix: 공지 사항 목록 조회시에 display되지 않는 필드는 포함하지 않도록 수정 (#63)
Browse files Browse the repository at this point in the history
  • Loading branch information
jungmir authored and YongJun-Lee-98 committed Feb 28, 2025
1 parent 1181a16 commit 26ee9cc
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 3 deletions.
8 changes: 7 additions & 1 deletion src/notice/serializers.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,13 @@
from .models import Notice


class NoticeSummarizeListSerializer(serializers.ModelSerializer):
class Meta:
model = Notice
fields = ["id", "title", "is_pinned"]


class NoticeSerializer(serializers.ModelSerializer):
class Meta:
model = Notice
fields = ["title", "content", "is_deleted", "is_pinned", "created_at", "updated_at"]
fields = ["id", "title", "content", "is_pinned", "created_at", "updated_at"]
10 changes: 8 additions & 2 deletions src/notice/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,22 @@
from core.responses.base import BaseResponse

from .models import Notice
from .serializers import NoticeSerializer
from .serializers import NoticeSerializer, NoticeSummarizeListSerializer
from .swagger import NoticeAPIDocs


@extend_schema_view(list=NoticeAPIDocs.list(), retrieve=NoticeAPIDocs.retrieve())
class NoticeViewSet(GenericViewSet):
serializer_class = NoticeSerializer
queryset = Notice.objects.filter(is_deleted=False)
filterset_fields = ("is_pinned",)

def get_serializer_class(self):
match self.action:
case "list":
return NoticeSummarizeListSerializer
case "retrieve":
return NoticeSerializer

def list(self, request, *args, **kwargs) -> BaseResponse:
queryset = self.get_queryset()
page = self.paginate_queryset(queryset)
Expand Down

0 comments on commit 26ee9cc

Please sign in to comment.