Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore consistent behaviour between *_sources.cmake and *_ctest.cmake #427

Merged

Conversation

Mikolaj-A-Kowalski
Copy link
Contributor

Should resolve issue #426.
It seems that the it was sufficient to avoid adding basenames to the test_sources_f90 list before all F90 files are set in add_pfunit_sources function

@Mikolaj-A-Kowalski Mikolaj-A-Kowalski requested a review from tclune as a code owner May 4, 2023 17:16
Copy link
Member

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but will not merge until I can test against some external projects.

Thank you for the contribution.

@tclune
Copy link
Member

tclune commented May 8, 2023

@Mikolaj-A-Kowalski Can you add an entry in the ChangeLog.md as well? Then I won't forget that when we do the merge.

Thx.

@Mikolaj-A-Kowalski
Copy link
Contributor Author

@Mikolaj-A-Kowalski Can you add an entry in the ChangeLog.md as well? Then I won't forget that when we do the merge.

Thx.

Certainly! Should be done now!
Thank you for the review.

@tclune tclune self-requested a review May 9, 2023 12:59
@tclune
Copy link
Member

tclune commented Jun 26, 2023

Sorry that I lost track of this. Have not gotten around to testing with other projects, but in all likelihood won't until forced by including in a release. So ... crossing fingers

@tclune tclune merged commit 247e23b into Goddard-Fortran-Ecosystem:main Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants