Use the fiscal start day of the month for relative quarter reports #2065
Conversation
Only the quarter's start month in reports is adjusted when Absolute is selected in the Start Date on the Accounting Period preferences. This branch adjusts both the quarter's start day and month when Absolute is selected or when Relative and Today, Start of this month, or Start of previous month are selected.
|
The test errors are expected as we're changing the prior relative quarter start behavior. |
Commented out the relative quarter tests that are no longer going to reliably succeed.
In only one place, so that the reports' understanding of the relative quarter differs from the rest of the program's. This is particularly amusing because it answers my "what am I missing" from #2064: In the absence of preferences, which is the case with unit tests, the default accounting period is That aside it appears from grepping around that the only other place that would be affected by this policy change is in the price database, where leaving the last quote of each quarter is an option for deleting old quotes. That's not exactly high-risk. However while I don't advocate as extensive a testing range as Graham Menhemnitt it does deserve more testing, not less. |
Only the quarter's start month in reports is adjusted when Absolute is selected in the Start Date on the Accounting Period preferences. This branch adjusts both the quarter's start day and month when Absolute is selected or when Relative and Today, Start of this month, or Start of previous month are selected.