[BUGFIX] Deleted Code that caused incompatibility with NutritionZ #884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While playing with both NutritionZ (1.0.11+1.21.1) and TAN (9.2.0.171+1.21.1) on Fabric, I discoverd a major incompatibility between these two mods causing NutritionZ to not track lost nutritional values.Normally in NutritionZ if you would lose hunger your nutritional values would go down by one unit, however when installing both this behavior would not work at all.
While looking at the source code of both mods I discoverd that NutritionZ uses mixins to alter the behavior of HungerManager.class where foodTickTimer resides. I am no expert in modding but by trial and error I found that these lines in TAN would cause a problem for NutritionZ.
Mixin in NutritionZ
I did this for my own survival world and I thought maybe other people might run into the same problem without knowledge in java.
Love your contribution to the community, much love!
EDIT:
My Discord: Marvin23