-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: replace JSX.Element with ReactNode type #2645
chore: replace JSX.Element with ReactNode type #2645
Conversation
Size Change: 0 B Total Size: 1.37 MB ℹ️ View Unchanged
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2645 +/- ##
==========================================
+ Coverage 81.03% 81.11% +0.08%
==========================================
Files 469 469
Lines 9929 9929
Branches 2348 2348
==========================================
+ Hits 8046 8054 +8
+ Misses 1762 1754 -8
Partials 121 121 ☔ View full report in Codecov by Sentry. |
Can we also do |
Maybe do this with the upcoming v13? We need to support |
🎉 This PR is included in version 12.13.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎯 Goal
Prevent @types/react@19 complaints about
string | JSX.Element
not being assignable toReactNode
.