-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: render Markdown within quoted message components #2640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7cfdc28
to
79511fe
Compare
Size Change: 0 B Total Size: 1.37 MB ℹ️ View Unchanged
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2640 +/- ##
==========================================
+ Coverage 81.03% 81.06% +0.02%
==========================================
Files 469 469
Lines 9930 9938 +8
Branches 2349 2351 +2
==========================================
+ Hits 8047 8056 +9
+ Misses 1762 1761 -1
Partials 121 121 ☔ View full report in Codecov by Sentry. |
oliverlaz
approved these changes
Feb 12, 2025
3ebddaf
to
07fc7cf
Compare
MartinCupela
approved these changes
Feb 18, 2025
07fc7cf
to
00c0967
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Feb 19, 2025
## [12.13.0](v12.12.0...v12.13.0) (2025-02-19) ### Bug Fixes * hide UnreadMessagesSeparator in threads ([#2650](#2650)) ([e58bc2a](e58bc2a)) ### Features * render Markdown within quoted message components ([#2640](#2640)) ([6674cc2](6674cc2)) ### Chores * **deps:** bump react peer dependency version to v16.14.0 ([#2644](#2644)) ([88b6dc8](88b6dc8))
🎉 This PR is included in version 12.13.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Currently, Markdown text is not being rendered properly within quoted messages (
renderText
omitted). This PR aims at addingrenderText
to bothQuotedMessage
andQuotedMessagePreview
components.Missing
span
selector (must include message input too), PRDO NOT MERGE BEFORE INSTALLING LATEST
@stream-io/stream-chat-css