add support for async export users endpoint #298
Conversation
.github/workflows/ci.yml
Outdated
| @@ -17,7 +17,7 @@ jobs: | |||
| max-parallel: 3 | |||
| fail-fast: false | |||
| matrix: | |||
| goVer: ['1.18', '1.19', '1.20', '1.21', '1.22', '1.23'] | |||
| goVer: ['1.18', '1.19', '1.20', '1.21', '1.22', '1.23', '1.24'] | |||
There was a problem hiding this comment.
what about updating the go.mod to use 1.24 and test only the latest 3 major versions?
There was a problem hiding this comment.
Hey @yaziine nice to hear from you, hope you're doing good! 😄
Bumping go.mod to 1.24 would set the minimum version to 1.24 no? Since it was released just about a week ago I dont think all customers have upgraded at this point. But I think setting it to 1.22 and test 1.22 -> 1.24 should be good right?
There was a problem hiding this comment.
no new features is being used otherwise the tests (for old versions) would have fail, but yeah better safe than sorry. setting to 1.22 seems to be a good move.
There was a problem hiding this comment.
Hey Yassine, want to do some chat development again? ;)
| @@ -1 +1 @@ | |||
| * @yaziine @totalimmersion @akupila @JimmyPettersson85 | |||
| * @totalimmersion @JimmyPettersson85 | |||
Submit a pull request
CLA
Description of the pull request
Adds support for the async export users endpoint in the Chat API.