양 끝에 아이콘을 추가할 수 있는 Edit Text & 검증 텍스트와 텍스트 제한 기능이 있는 Edit Text 구현 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…viewBinding 설정
…t Start Icon 속성 구현
…t End Icon 속성 구현
…ext -> Royal Flush Icon Edit Text로 변경
…동작을 지정하는 확장 함수 추가
soopeach
requested review from
bngsh,
ldh019,
yangsooplus,
jeeminimini and
swjw13
6 tasks
github-actions
bot
added
🎀 Design
swjw13
approved these changes
May 18, 2023
검증된 텍스트의 길이가 엄청 길어지게 될 거라고는 생각을 못했어요..!! 고려(호랑이)해봐야겠습니다. |
ldh019
requested changes
May 22, 2023
| <selector > | ||
| <item xmlns:android="http://schemas.android.com/apk/res/android"> | ||
| <shape android:shape="rectangle"> | ||
| <solid android:color="#DFDBCC" /> |
There was a problem hiding this comment.
이런 리소스에 있는 hex color도 테마에 미리 정해놓은걸로 쓸수있나요?
| @@ -0,0 +1,54 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <androidx.constraintlayout.widget.ConstraintLayout xmlns:android="http://schemas.android.com/apk/res/android" | |||
There was a problem hiding this comment.
ConstraintLayout이 중첩으로 쓰인 이유가 있을까요?
There was a problem hiding this comment.
Linear로 개선이 가능해보이네요 감사합니다!
| android:background="@drawable/royal_flush_edit_text_background"> | ||
|
|
||
| <ImageView | ||
| android:id="@+id/start_ic" |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolved: #9
작업 내용
사용 방법
RoyaFlushIconEditText
royalFlushIconEditTextHint속성으로 힌트 지정 가능.startIcon속성으로 시작 쪽 아이콘 지정 가능.endIcon속성으로 끝 쪽 아이콘 지정 가능.RoyalFlushVerificationEditText
royalFlushVerificationEditTextHint속성으로 힌트 지정 가능.isCounterVisible속성으로 텍스트 카운터 텍스트 visibility 여부 지정 가능.isVerificationVisible속성으로 초기 검증 텍스트 visibility 지정 가능.verificationText속성으로 초기 검증 텍스트 지정 가능.maxLength최대 글자 수 제한 가능.RoyalFlushVerificationEditText 추가 기능