Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: usd calculation #1863

Merged
merged 2 commits into from
Feb 26, 2025
Merged

fix: usd calculation #1863

merged 2 commits into from
Feb 26, 2025

Conversation

helciofranco
Copy link
Member

Summary

Fix USD calculation and add unit tests to ensure we'll not face it again.

📷 Demo
Screenshot 2025-02-25 at 20 37 18

Checklist

  • I've added error handling for all actions/requests, and verified how this error will show on UI. (or there was no error handling)
  • I've reviewed all the copy changed/added in this PR, using AI if needed. (or there was no copy changes)
  • I've included the reference to the issues being closed from Github and/or Linear (or there was no issues)
  • I've changed the Docs to reflect my changes (or it was not needed)
  • I've put docs links where it may be helpful (or it was not needed)
  • I checked the resulting UI both in Light and Dark mode (or no UI changes were made)
  • I reviewed the entire PR myself (preferably, on GH UI)

@helciofranco helciofranco linked an issue Feb 26, 2025 that may be closed by this pull request
@helciofranco helciofranco self-assigned this Feb 26, 2025
@helciofranco helciofranco merged commit f82963e into master Feb 26, 2025
26 of 27 checks passed
@helciofranco helciofranco deleted the hf/fix/value-in-usd-calculation branch February 26, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix value in USD calculation
3 participants