Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Youtube privacy #31

Open
wants to merge 2 commits into
base: 1.x
Choose a base branch
from
Open

Youtube privacy #31

wants to merge 2 commits into from

Conversation

imorland
Copy link
Member

Modifies the Youtube embed template to render youtube-nocookie.com in place of youtube.com, for privacy focussed reasons.

However, we need to consider:

  • Forcing this may or may not be popular
  • To date, this extension has been config free, so placing this behind an option would go against that
  • Maybe this should be left to forum admins to set in their local extend.php
  • Or this should be a seperate micro-extension.

Anyhow, I'll leave this here for a while to gather comments, opinions, etc

@imorland imorland linked an issue Jun 29, 2021 that may be closed by this pull request
@clarkwinkelmann
Copy link
Member

Do other of the embed websites could do with such a change?

Maybe this would be better as a standalone extension that changes multiple embeds and/or other Flarum features to a strict privacy mode.

Just looking at the PR code I was wondering, if someone wanted to disable youtube embeds completely, does the code now prevent it or not? Assuming there's some kind of remove method that they might call from extend.php. I just wonder if adding it explicitly prevents local extend.php or other extensions from disabling it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use (optionally?) Youtube privacy enhanced mode for GDPR compliance
2 participants