-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
weston-init: Launch as root for i.MX93 #2032
base: master
Are you sure you want to change the base?
Conversation
imx-pxp-g2d needs root access to * /dev/pxp_device * /dev/dma_heap/linux,cma* Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
@@ -92,3 +92,10 @@ do_install:append() { | |||
sed -i -e "s/^xwayland=true/#xwayland=true/g" ${D}${sysconfdir}/xdg/weston/weston.ini | |||
fi | |||
} | |||
|
|||
do_install:append:mx93-nxp-bsp() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to adjust the permissions so we could avoid this process to run as root?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would agree for /dev/pxp_device
but I have no idea if it is a good idea to lift the accesspermissions for /dev/dma_heap/linux,cma*
Another question is. Are these all paths?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thochstein Is it possible for you to check internally what are the devices that we need to provide access?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the reminder, asking again for input.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @tq-steina and @otavio ,
I tried internally and both /dev/pxp_device and /dev/dma_heap/linux,cma* need provide the access.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WujianSun did also suggest adding GROUP="video"
to work with user weston
. We need it for Mali as well:
KERNEL=="linux,cma*", NAME="dma_heap", MODE="0664", GROUP="video"
KERNEL=="mali[0-9]", MODE="0664", GROUP="video"
KERNEL=="pxp_device", MODE="0664", GROUP="video"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @thochstein ,
Yes, need add to video Group.
7fb496c
to
c026067
Compare
imx-pxp-g2d needs root access to